Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Replacing TS any by unknown, as using any is highly NOT recommended #3661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

@cassiano
Copy link
Contributor

@cassiano cassiano commented Sep 26, 2025

Replacing TS any by unknown, as using any is highly NOT recommended

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named
  • meets the standards outlined in the accessibility guidelines

Copy link
Contributor Author

@raclim, you might want to check with your dev team if they agree with my proposed changes. I personally NEVER use any, unless under some very exceptional circumstances.

raclim reacted with thumbs up emoji

Copy link
Collaborator

raclim commented Sep 26, 2025

Thanks for the suggestion!

Will tag @clairep94 and @khanniie to chime in on this, since they have been leading the TypeScript migration work!

Copy link
Member

if typechecks pass idm merging it in! defer to @clairep94 on if she had a reason for using one over the other, i recall we may have had a conversation on a PR about using any but i forget if it was about this particular case and were we ended up on it

Copy link
Collaborator

raclim commented Oct 20, 2025

I'm going to merge this in since it makes sense to me, but please feel free to follow up if any thoughts come up!

@raclim raclim merged commit 297ebde into processing:develop Oct 20, 2025
1 check passed
@cassiano cassiano deleted the replacing-any-by-unknown-as-a-good-practice-in-ts branch October 21, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raclim raclim raclim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /