-
-
Couldn't load subscription status.
- Fork 2.7k
Fix issue with default renderer when ipython is installed
#5258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marthacryan
marthacryan
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I followed the test steps above and everything worked correctly (including the Jupyter notebook with a local package).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Closes #5257
Reverts change to
plotly/io/_renderers.pyadded in #5096 to keep the original logic flow of the if statement.Adds a test to ensure that the default renderer is
"browser"while running the tests; since thetest_optionalworkflow installsjupyterwhich installsipython, this should prevent a regression.Steps to test
main:pip install jupyterpython -c "import plotly.express as px; fig = px.scatter(x=[1], y=[1]); fig.show()". This SHOULD show a figure in the browser, but instead it prints the HTML/JS to the terminal output.python -c "import plotly.express as px; fig = px.scatter(x=[1], y=[1]); fig.show()"and make sure the figure is shown in the browsermain.jupyter notebookto launch the notebook editor, and create a new notebook