Commit d2af541

authored

Merge pull request #5258 from plotly/fix-default-renderer-when-ipython-installed

Fix issue with default renderer when `ipython` is installed

2 parents aa4c088 + 75ae9d3 commit d2af541Copy full SHA for d2af541

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -485,7 +485,7 @@ def show(fig, renderer=None, validate=True, **kwargs):`
`485`	`485`	`)`
`486`	`486`
`487`	`487`	`default_renderer = env_renderer`
`488`		`-elif ipython:`
	`488`	`+elif ipythonandipython.get_ipython():`
`489`	`489`	`# Try to detect environment so that we can enable a useful`
`490`	`490`	`# default renderer`
`491`	`491`	`if not default_renderer:`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,13 @@ def fig1(request):`
`33`	`33`	`)`
`34`	`34`
`35`	`35`
	`36`	`+def test_default_renderer():`
	`37`	`+ """`
	`38`	`+ The default renderer should be 'browser'.`
	`39`	`+ """`
	`40`	`+ assert pio.renderers.default == "browser"`
	`41`	`+`
	`42`	`+`
`36`	`43`	`# JSON`
`37`	`44`	`# ----`
`38`	`45`	`def test_json_renderer_mimetype(fig1):`

Comments

(0)