-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add back the mime renderer JL extension #5096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f942e97 to
847b87c
Compare
Pinning the version of shapely here for tests to pass, but we should address that in another PR.
@marthacryan Looks good! Can you update
CONTRIBUTING.mdto explain how the Jupyterlab extension build process works (and also explain the new CI step)?
Done! Want to take a quick look to see if it makes sense?
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
bcfbd25 to
f3a4278
Compare
.github/workflows/check-js-build.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. Also got that from the other script
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
Update CONTRIBUTING.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Uh oh!
There was an error while loading. Please reload this page.
Fixes #5056 by adding back a mime renderer extension removed in #4822. We didn't realize at the time that this part of the code was serving an important purpose in keeping filesizes down for offline users.