-
Notifications
You must be signed in to change notification settings - Fork 112
Use real object managers #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use real object managers #49
Conversation
f6f7380 to
7e7fce1
Compare
Based on the class metadata we can easily fetch data from any configuration format.
7e7fce1 to
f07d357
Compare
I'll look into this ASAP.
What's cool that it will allow more precise info for purposes like magic findBy methods on repositories (like #35) and gasp static DQL validation!
Not so sure about 0b810f7 - is the good approach for this problem?
It's not needed - you can ask instanceof $string.
0b810f7 to
88def91
Compare
It's not needed - you can ask
instanceof $string.
In 1cc26d1, But phpstan doesn't get it, so still need to alias $metadata and use @var... its slightly better, and you cannot instance 'Literal' so its not very pretty...
Without the alias, I get
------ ----------------------------------------------------------------------------------------------------------------
Line src/Type/Doctrine/ObjectMetadataResolver.php
------ ----------------------------------------------------------------------------------------------------------------
52 Access to an undefined property Doctrine\Common\Persistence\Mapping\ClassMetadata::$customRepositoryClassName.
57 Access to an undefined property Doctrine\Common\Persistence\Mapping\ClassMetadata::$customRepositoryClassName.
------ ----------------------------------------------------------------------------------------------------------------
88def91 to
1cc26d1
Compare
@mcfedr thanks for picking things up and continuing the work 👍 Way too many things got in my way and I couldn't continue.
@mcfedr thanks for picking things up and continuing the work 👍 Way too many things got in my way and I couldn't continue.
yes, these things happen, I had some time and saw stuff so nearly ready that I'm excited to use. Hopefully we can finish these things off asap and get a new release out.
On that note, I must say thanks @ondrejmirtes for being available and ready to review this and the other PRs today.
Thank you! 👍
This is mind-blowing: 0947875
#40, rebased on #48
as in the original, with this implementation we're able to use the class metadata to retrieve repository information, given the user provides the entity/document manager instance.
Additionally, will use default
repositoryClasswhen noobjectManagerLoaderis provided.