-
Notifications
You must be signed in to change notification settings - Fork 112
Add support for magic find* entity repository methods #35 #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
keelerm84
commented
Nov 15, 2018
I believe this PR would also fix some issues I'm having. If the tests were passing, would this likely get merged?
Thanks for the comment 😄 I've fixed the tests - was just CS issues.
Hi, this PR does not take full advantage of static analyser - ideally, it should know which exact findBy methods exist. It should be possible once the entity metadata are available from other PRs.
I agree, @ondrejmirtes. I wanted to implement that behaviour but wasn't able to easily achieve it. Hopefully, that's something that can be improved when the API becomes available?
Hi, this will need to be reworked in light of #49 - it will allow you to find out which findBy methods are really there based on the entity :)
Thanks! I'll implement the checks as a rule.
Implemented the rest: 5bf58a3
No description provided.