-
-
Couldn't load subscription status.
- Fork 54
Convert Request, Response, CodeResponseType, TokenResponseType to ES6 classes #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Request, Response, CodeResponseType, TokenResponseType to ES6 classes #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@menewman I got some small comments, could you please update these?
@jankapunkt PR seems fine. Could you also review this so this one can be merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some minor changes but I think at keast to has own property checks should be considered, even if the attack surface is rather superficial and imaginary
Summary
Chipping away at #212 by converting four more classes:
(Do note that TokenResponseType's constructor simply throws a not implemented error, though. So that conversion was easy. 😉)
Linked issue(s)
A few checkboxes of #212 (but not the whole thing).
Involved parts of the project
Specifically the classes noted above, which affect pretty much everything (since Request/Response are core parts of the interface). But, there are no functional changes.
Added tests?
I did not update the tests, but these files are already covered under the existing tests, which should continue to pass after this refactoring.
OAuth2 standard
N/A
Reproduction
N/A