Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Release 5.0.0 #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jankapunkt merged 65 commits into development from release-5.0.0
Nov 6, 2023
Merged

Release 5.0.0 #194

jankapunkt merged 65 commits into development from release-5.0.0
Nov 6, 2023

Conversation

@jankapunkt
Copy link
Member

@jankapunkt jankapunkt commented Jun 22, 2023
edited
Loading

Summary

Release 5.0.0

Added tests?

Copy link
Member Author

The CI fails, because https://github.com/node-oauth/express-oauth-server tests fail (in tests for release) so we need to update this repo, too.

jankapunkt and others added 10 commits July 10, 2023 15:14
...n body
Merge pull request #197 from node-oauth/fix-pkce-missing-query
Merge pull request #203 from MaximilianGaedig/patch-1 thanks to @MaximilianGaedig 
Copy link
Member Author

Released v5.0.0-rc.1

Copy link
Member Author

@jorenvandeweyer thanks for the review, I will wait a few more days to see if anyone reports issues with the RC. Maybe until end of next week or rather end of the month?

Copy link
Member Author

This is blocked until #219 is properly covered

Copy link
Member Author

shrihari-prakash and jorenvandeweyer reacted with heart emoji

Copy link
Member

Nice! I propose we release v5 in the week of 6 november?

I'm seeing a lot of download on the rc.4 version.

shrihari-prakash and jankapunkt reacted with thumbs up emoji

Copy link
Member Author

Yes! Let's fix the 6th as release date

jorenvandeweyer and shrihari-prakash reacted with hooray emoji

Copy link
Collaborator

On my side, no issues in my production apps since rc5 upgrade so far. Things have been pretty good ever since rc4!

Copy link
Member Author

@jorenvandeweyer @shrihari-prakash I generated documentation for 5.0.0 including a little migration guide here: https://node-oauthoauth2-server.readthedocs.io/en/release-5.0.0/index.html

Please review it and let me know if it's all good then I will publish 5.0.0 today.

Copy link
Collaborator

@jankapunkt on my side, I see only 2.x to 3.x migration. Is this normal?
image

jankapunkt reacted with thumbs up emoji

Copy link
Collaborator

Also, I don't know much about how read the docs works, but is the TOC supposed to show only the current section we are reading?
image
Isn't this difficult to navigate?

jankapunkt reacted with thumbs up emoji

Copy link
Member Author

So the link should be fixed. Regarding the navigation I found that read the docs changed their config model and the previous theme is not available anymore without adding tons of more config (requirements files, project.toml). I can look for a different theme but it should be builtin

shrihari-prakash reacted with thumbs up emoji

Copy link
Member Author

@shrihari-prakash the old theme is active now

shrihari-prakash reacted with thumbs up emoji

Copy link
Collaborator

shrihari-prakash commented Nov 6, 2023
edited
Loading

Looks perfect now! @jankapunkt . Ok with the content as well.

Copy link
Member Author

@jorenvandeweyer @shrihari-prakash I finally published 5.0.0 🎉

shrihari-prakash and jorenvandeweyer reacted with rocket emoji

@jankapunkt jankapunkt merged commit ca71f60 into development Nov 6, 2023
Copy link
Collaborator

@jankapunkt still don't see it yet?
image

Copy link
Member Author

It's on NPM released, the GitHub release is waiting until I have merged it into master

shrihari-prakash reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorenvandeweyer jorenvandeweyer jorenvandeweyer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v5

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /