-
-
Couldn't load subscription status.
- Fork 54
Release 5.0.0 #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 5.0.0 #194
Conversation
The CI fails, because https://github.com/node-oauth/express-oauth-server tests fail (in tests for release) so we need to update this repo, too.
...n body Merge pull request #197 from node-oauth/fix-pkce-missing-query
Merge pull request #203 from MaximilianGaedig/patch-1 thanks to @MaximilianGaedig
Fix ci for release-tests
Released v5.0.0-rc.1
Removed callback support in typings file.
@jorenvandeweyer thanks for the review, I will wait a few more days to see if anyone reports issues with the RC. Maybe until end of next week or rather end of the month?
This is blocked until #219 is properly covered
Nice! I propose we release v5 in the week of 6 november?
I'm seeing a lot of download on the rc.4 version.
Yes! Let's fix the 6th as release date
On my side, no issues in my production apps since rc5 upgrade so far. Things have been pretty good ever since rc4!
@jorenvandeweyer @shrihari-prakash I generated documentation for 5.0.0 including a little migration guide here: https://node-oauthoauth2-server.readthedocs.io/en/release-5.0.0/index.html
Please review it and let me know if it's all good then I will publish 5.0.0 today.
@jankapunkt on my side, I see only 2.x to 3.x migration. Is this normal?
image
Also, I don't know much about how read the docs works, but is the TOC supposed to show only the current section we are reading?
image
Isn't this difficult to navigate?
So the link should be fixed. Regarding the navigation I found that read the docs changed their config model and the previous theme is not available anymore without adding tons of more config (requirements files, project.toml). I can look for a different theme but it should be builtin
@shrihari-prakash the old theme is active now
Looks perfect now! @jankapunkt . Ok with the content as well.
@jorenvandeweyer @shrihari-prakash I finally published 5.0.0 🎉
@jankapunkt still don't see it yet?
image
It's on NPM released, the GitHub release is waiting until I have merged it into master
Uh oh!
There was an error while loading. Please reload this page.
Summary
Release 5.0.0
Added tests?
because the CI actually runs extra tests in this package on release-* branches