-
Notifications
You must be signed in to change notification settings - Fork 536
FIX: Address numpy and traits deprecations #3699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #3699 +/- ## ========================================== + Coverage 70.81% 72.86% +2.04% ========================================== Files 1277 1278 +1 Lines 59153 59305 +152 Branches 8590 0 -8590 ========================================== + Hits 41890 43212 +1322 + Misses 16119 16093 -26 + Partials 1144 0 -1144 ☔ View full report in Codecov by Sentry. |
Okay, moving to tox because this CI is a pain to work with.
@effigies
effigies
force-pushed
the
fix/deprecations
branch
2 times, most recently
from
November 18, 2024 14:46
0aafdfc to
d4f56eb
Compare
@effigies
effigies
force-pushed
the
fix/deprecations
branch
from
November 18, 2024 14:46
d4f56eb to
a150eeb
Compare
mgxd
mgxd
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To unlock projects that want to support numpy 2, we need to disable our pin and fix some bugs that were probably generated in the 2to3 transition, namely using
np.savetxt(..., fmt=b'...').Started to test on Python 3.13, but we're blocked on a release of traits. Ran with latest master and addressed deprecations.
@mgxd Would you be up for a quick review?