Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

BF: Update dcmstack interface for Py3 / newer pydicom #3541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
effigies merged 1 commit into nipy:master from moloney:bf-dcmstack
Mar 2, 2023

Conversation

@moloney
Copy link
Contributor

@moloney moloney commented Jan 31, 2023

Summary

Fixes issues with dcmstack interface on Python3 with newer pydicom.

List of changes proposed in this PR (pull-request)

Copy link

codecov bot commented Jan 31, 2023 •
edited
Loading

Codecov Report

Base: 63.63% // Head: 63.62% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (071a40e) compared to base (7382b3d).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files 
@@ Coverage Diff @@
## master #3541 +/- ##
==========================================
- Coverage 63.63% 63.62% -0.02% 
==========================================
 Files 309 309 
 Lines 40873 40900 +27 
 Branches 5381 5381 
==========================================
+ Hits 26011 26021 +10 
- Misses 13838 13855 +17 
 Partials 1024 1024
Impacted Files Coverage Δ
nipype/interfaces/dcmstack.py 35.10% <33.33%> (ø)
nipype/interfaces/cmtk/cmtk.py 17.75% <0.00%> (-0.15%) ⬇️
nipype/interfaces/cmtk/nx.py 17.73% <0.00%> (-0.07%) ⬇️
nipype/interfaces/cmtk/convert.py 27.01% <0.00%> (-0.05%) ⬇️
nipype/interfaces/cmtk/nbs.py 32.98% <0.00%> (+0.02%) ⬆️
nipype/pipeline/plugins/base.py 58.88% <0.00%> (+0.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

Thanks, Brendan. It looks like this doesn't get exercised by any tests. Is it feasible to add a test that would catch a future breakage?

@effigies effigies merged commit cdfe679 into nipy:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /