-
Notifications
You must be signed in to change notification settings - Fork 536
MNT: Pin traits < 6.4 #3501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Pin traits < 6.4 #3501
Conversation
This basically sets a lifetime on nipype 1.x. Refactoring to work with breaking changes in traits seems more work than it's worth (and would presumably break with older traits).
This fixes the breaking tests in master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on capping traits over a massive refactor. We should get this in for the next batch of nipreps releases.
re: the failing tests - it seems not all output compcor lists are numpy arrays. weird that this hasn't shown up in other PRs, but the fix should be a simple coercion
8c17f1a to
ac1e2d1
Compare
Codecov Report
@@ Coverage Diff @@ ## master #3501 +/- ## ======================================= Coverage 65.25% 65.25% ======================================= Files 309 309 Lines 40858 40859 +1 Branches 5379 5379 ======================================= + Hits 26662 26663 +1 Misses 13122 13122 Partials 1074 1074
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@mgxd Please merge if you're happy with this.
This basically sets a lifetime on nipype 1.x. Refactoring to work with breaking changes in traits seems more work than it's worth (and would presumably break with older traits).
Summary
Fixes # .
List of changes proposed in this PR (pull-request)