Commit 8c17f1a

committed

TEST: Coerce close_up_to_column_sign args to arrays before checking for equality

1 parent f4a1f52 commit 8c17f1aCopy full SHA for 8c17f1a

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,8 @@`
`12`	`12`
`13`	`13`	`def close_up_to_column_sign(a, b, rtol=1e-05, atol=1e-08, equal_nan=False):`
`14`	`14`	`"""SVD can produce sign flips on a per-column basis."""`
	`15`	`+ a = np.asanyarray(a)`
	`16`	`+ b = np.asanyarray(b)`
`15`	`17`	`kwargs = dict(rtol=rtol, atol=atol, equal_nan=equal_nan)`
`16`	`18`	`if np.allclose(a, b, **kwargs):`
`17`	`19`	`return True`
`@@ -33,8 +35,6 @@ def close_up_to_column_sign(a, b, rtol=1e-05, atol=1e-08, equal_nan=False):`
`33`	`35`	`],`
`34`	`36`	`)`
`35`	`37`	`def test_close_up_to_column_sign(a, b, close):`
`36`		`- a = np.asanyarray(a)`
`37`		`- b = np.asanyarray(b)`
`38`	`38`	`assert close_up_to_column_sign(a, b) == close`
`39`	`39`	`# Sign flips of all columns never changes result`
`40`	`40`	`assert close_up_to_column_sign(a, -b) == close`

Comments

(0)