-
Notifications
You must be signed in to change notification settings - Fork 536
FIX: Add tolerance parameter to ComputeDVARS #3489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Directly coerce image dataobj attributes, and mask idiomatically Replace interpolation with method in np.percentile (interpolation deprecated) Call AR_est_YW indirectly to avoid coercion of tuple(array, float)
fff5bab to
75a78e0
Compare
Codecov Report
@@ Coverage Diff @@ ## master #3489 +/- ## ======================================= Coverage 65.25% 65.25% ======================================= Files 309 309 Lines 40846 40849 +3 Branches 5378 5378 ======================================= + Hits 26655 26658 +3 Misses 13117 13117 Partials 1074 1074
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nipype/algorithms/confounds.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the chance someone is relying on this function, I'd recommend adding this new parameter at the end, or shifting all defaults to be keyword-only.
Closes #3487.
Also made some changes to avoid numpy deprecation warnings, and used nibabel 3+ idioms for coercing data types.