-
Notifications
You must be signed in to change notification settings - Fork 536
FIX: Use interpolation/method in numpy.percentile as available #3506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 65.26% // Head: 65.25% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@ ## master #3506 +/- ## ========================================== - Coverage 65.26% 65.25% -0.01% ========================================== Files 309 309 Lines 40870 40873 +3 Branches 5380 5380 ========================================== + Hits 26672 26673 +1 - Misses 13124 13126 +2 Partials 1074 1074
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@mgxd Would you mind giving this a quick glance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - is this something we should track and remove once 1.22 becomes the minimum?
I generally try to grep for PY strings when bumping minimum Python and NP strings when bumping minimum numpy, so the comment there is my tracking plan.
Bug introduced in #3489. Numpy 1.22 introduced method and deprecated interpolation in a single shot. Typically, they deprecate a few versions after they introduce an alternative, so I missed this and now things that have pinned, e.g., numpy 1.21 are going to break on nipype.