-
-
Notifications
You must be signed in to change notification settings - Fork 496
Discord Rich Presence support #3167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test case with load data
CrosRoad95
commented
Sep 2, 2023
here's our favourite issue back again, vendor libraries inflate pull requests, either: 1. download sources from some server, 2. use submodule
because now reviewing it is hard due to laggy browser :)
here's our favourite issue back again, vendor libraries inflate pull requests, either: 1. download sources from some server, 2. use submodule
because now reviewing it is hard due to laggy browser :)
Sorry, but due to the fact that I have an edited version of discord-rpc I had to add it.
If you want i can redo it.
CrosRoad95
commented
Sep 2, 2023
i don't want to discuss the same issue over and over for every case, i want general solution
@CrosRoad95 Please leave comments like that to the project maintainers (MTA team/write access). Avoid dragging contributors down on their PR's, if those responsible want to update coding guidelines then they can do it separately and in its own discussion. Don't reply to this post, let's keep it on topic, thanks.
@znvjder Don't mind it, vendor\discord-rpc in this PR is fine
Who uses a mobile browser to review code anyways, im on desktop and it scrolls smoothly.
Nice PR, and heavily awaited!
Commenting for support and exposure. Nice PR, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly seems good to me, just a couple of small comments.
You also mentioned "due to the fact that I have an edited version of discord-rpc I had to add it." - in this case we would want to commit those changes to https://github.com/multitheftauto/discord-rpc and restore the install_discord script. You should be able to make a pull request to the master branch of that repository with the changes.
This way we retain the install_discord premake script & exclude the vendor files from the mtasa-blue repo, which is definitely preferable.
It would be really nice to have a test resource showing examples of all functions. They will need to be written for the wiki anyway.
Good work and thanks for picking up the branch!
To be merged along with this: multitheftauto/discord-rpc#1
The branch got borked by our simultaneous commits, it's fixed now. I've kept the v in the tag for consistency (I made a mistake when creating 3.4.2).
Based on fork #2577
I decided to copy the code from the base fork and rework it due to compilation problems.
What has changed:
Below are some of the features:
Example on Discord:
drpc
All that was left was to add a default resource to show additional data.
I have no idea what else to add, so I'm open to suggestions.