Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add discord-rpc #2577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Deihim007 wants to merge 40 commits into multitheftauto:master from Deihim007:pr/2499
Closed

Add discord-rpc #2577

Deihim007 wants to merge 40 commits into multitheftauto:master from Deihim007:pr/2499

Conversation

@Deihim007
Copy link
Contributor

@Deihim007 Deihim007 commented Mar 22, 2022 •
edited
Loading

Based on #2499
Prior discussions/implementations #721, #1031, #1570

This PR adds basic discord-rpc features to the client.
(Other features will be added later on a separate PR)

Todo:

  • Todolist
  • Add discord-rpc
    • Installation script
    • dependencies (rapidjson)
  • State:
    • Main Menu
    • In-game
      • Elapsed time

Maybe:

  • Default game-mode implementation
    • Idle (Custom state)
    • Loading
    • Player count ?
  • Custom Application Id
    • Server-side function
    • Client settings option to disable it (prevent potential abuse)
    • Wiki tutorial
      • How to make an application on discord developer portal
        • Assets template ?

Fernando-A-Rocha, Lpsd, turret001, theSarrum, Proxy-99, MobinYengejehi, Bence58, syncc01, and Nico8340 reacted with hooray emoji Bence58, turret001, Fernando-A-Rocha, Unde-R, Proxy-99, and MobinYengejehi reacted with heart emoji Bence58, turret001, Fernando-A-Rocha, Unde-R, Proxy-99, lopezloo, syncc01, and bum8hj reacted with rocket emoji
Lpsd and others added 15 commits January 5, 2022 01:00
@Lpsd Lpsd mentioned this pull request Mar 29, 2022
@patrikjuvonen patrikjuvonen added the enhancement New feature or request label Apr 2, 2022
@patrikjuvonen patrikjuvonen linked an issue Apr 15, 2022 that may be closed by this pull request
@patrikjuvonen patrikjuvonen added the feedback Further information is requested label Dec 30, 2022
@patrikjuvonen patrikjuvonen marked this pull request as draft December 30, 2022 19:59
Copy link
Contributor

Fernando-A-Rocha commented Feb 16, 2023 •
edited
Loading

I think we can prioritize making customization features for servers to decide what shows on their players' Discord Rich Presence when in-game. Imo, the PR can be merged once this is complete.

Then, allowing servers to integrate custom applications to their servers is something that can be addressed separately.
bum8hj, ahmadezzo, and Unbreakablex reacted with thumbs up emoji JrSchmidtt reacted with thumbs down emoji

Copy link
Contributor

This draft pull request is stale because it has been open for at least 90 days with no activity. Please continue on your draft pull request or it will be closed in 30 days automatically.

@github-actions github-actions bot added the stale Inactive for over 90 days, to be closed label Jun 24, 2023
Copy link
Contributor

This draft pull request was closed because it has been marked stale for 30 days with no activity.

Copy link
Member

Dutchman101 commented Aug 5, 2023 •
edited
Loading

We need someone to adopt this PR
Removed draft status, as todo list has been fully checkmarked, so that should have been outdated

@Dutchman101 Dutchman101 marked this pull request as ready for review August 5, 2023 19:35
znvjder added a commit to znvjder/mtasa-blue that referenced this pull request Aug 28, 2023
znvjder added a commit to znvjder/mtasa-blue that referenced this pull request Aug 28, 2023
Lpsd added a commit that referenced this pull request Oct 11, 2023 
* get draft from #2577
* get draft from #2577
* add checkbox to allow connecting with discord-rpc
test case with load data
* safe delete only if used
* fix vars when game is launching
* add function to set appid and small fixes
* added functions to manage assets, small fixes and bugs
* rewriten setAsset, refactor littlebit
* add function to check client connection with discord
* add buttons to rpc
* minor amendments, renaming of functions
* remove update discord-rpc from build
* thats too
* Memory leak fixed, presence updated on app change
* Presence state change, change of time variable
* Fixed unable to change custom state
* Added const to IsDiscordRPCEnabled
* Added missing argument validation
* Exclude vendor files, added premake script
* Re-run actions
* Bump discord-rpc version
* Fix broken discord tag_name
* Bump discord-rpc version
* Revert to 2b42cd9
* Bump discord-rpc version
* Disabled data customization if the app is not own
* Change DEFAULT_APP_ID
* Remove comment
---------
Co-authored-by: Lpsd <40902730+Lpsd@users.noreply.github.com>
Copy link
Member

Lpsd commented Oct 11, 2023

Superseded by #3167

@Lpsd Lpsd closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tederis tederis tederis left review comments

@Lpsd Lpsd Lpsd left review comments

@botder botder botder requested changes

+1 more reviewer

@CrosRoad95 CrosRoad95 CrosRoad95 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request feedback Further information is requested stale Inactive for over 90 days, to be closed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Discord RPC

AltStyle によって変換されたページ (->オリジナル) /