This repository was archived by the owner on Feb 2, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 496
[Demo Project] changed html bookmarks to scrollToElement function #1547
Merged
shanmukhateja
merged 1 commit into
l-lin:master
from
theprogrammersingh:console-error-in-base-demo-component
May 13, 2021
Merged
[Demo Project] changed html bookmarks to scrollToElement function #1547
shanmukhateja
merged 1 commit into
l-lin:master
from
theprogrammersingh:console-error-in-base-demo-component
May 13, 2021
+18
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @simarpreetsinghkalra
Thank you for fixing this. I've been putting it off for sometime now.
Could you reword your Git commit to as follows: "fix(demo): error log when scrolling via Action buttons" ?
@theprogrammersingh
theprogrammersingh
force-pushed
the
console-error-in-base-demo-component
branch
from
May 13, 2021 11:02
5984cec to
cb56ea2
Compare
Hey @shanmukhateja
Does the commit message looks good now?
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed console error in base-demo.component on the Docs website.
Replaced the HTML bookmarks for Preview, HTML and TypeScript with a function call which will enable the smooth scroll effect.