This repository was archived by the owner on Feb 2, 2025. It is now read-only.

Commit 131029e

authored

Merge pull request #1547 from simarpreetsinghkalra/console-error-in-base-demo-component

[Demo Project] changed html bookmarks to scrollToElement function

2 parents 740147c + cb56ea2 commit 131029eCopy full SHA for 131029e

File tree

2 files changed

+18

-14

lines changed

demo/src/app/base-demo
- base-demo.component.html
- base-demo.component.ts

2 files changed

+18

-14

lines changed

`‎demo/src/app/base-demo/base-demo.component.html‎`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -17,20 +17,20 @@ <h1 class="header center-on-small-only">{{pageTitle}}</h1>`
`17`	`17`	`<markdown [src]="mdInstall" *ngIf="mdInstall.length > 0"></markdown>`
`18`	`18`	`<div class="showcase-tabs">`
`19`	`19`	`<ul class="anchor-links">`
`20`		`- <li class="col s4"><a class="waves-effect btn" href="#preview">Preview</a></li>`
`21`		`- <li class="col s4"><a class="waves-effect btn" href="#html">HTML</a></li>`
`22`		`- <li class="col s4"><a class="waves-effect btn" href="#ts">Typescript</a></li>`
	`20`	`+ <li class="col s4"><a class="waves-effect btn" (click)="scrollToElement(preview)">Preview</a></li>`
	`21`	`+ <li class="col s4"><a class="waves-effect btn" (click)="scrollToElement(html)">HTML</a></li>`
	`22`	`+ <li class="col s4"><a class="waves-effect btn" (click)="scrollToElement(ts)">Typescript</a></li>`
`23`	`23`	`</ul>`
`24`	`24`	`</div>`
`25`		`- <div id="preview" class="col s12 m9 l12">`
	`25`	`+ <div #preview class="col s12 m9 l12">`
`26`	`26`	`<h4 class="header">Preview</h4>`
`27`	`27`	`<ng-container *ngTemplateOutlet="template"></ng-container>`
`28`	`28`	`</div>`
`29`		`- <div id="html" class="col s12 m9 l12">`
	`29`	`+ <div #html class="col s12 m9 l12">`
`30`	`30`	`<h4 class="header">HTML</h4>`
`31`	`31`	`<markdown [src]="mdHTML"></markdown>`
`32`	`32`	`</div>`
`33`		`- <div id="ts" class="col s12 m9 l12">`
	`33`	`+ <div #ts class="col s12 m9 l12">`
`34`	`34`	`<h4 class="header">{{mdTSHeading}}</h4>`
`35`	`35`	`<markdown [src]="mdTS"></markdown>`
`36`	`36`	`<ng-container *ngIf="mdTSHigh.length > 0">`

`‎demo/src/app/base-demo/base-demo.component.ts‎`

Lines changed: 12 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,30 +10,34 @@ export class BaseDemoComponent {`
`10`	`10`	`constructor() { }`
`11`	`11`
`12`	`12`	`@Input()`
`13`		`- pageTitle: string = '';`
	`13`	`+ pageTitle = '';`
`14`	`14`
`15`	`15`	`@Input()`
`16`		`- mdIntro: string = '';`
	`16`	`+ mdIntro = '';`
`17`	`17`
`18`	`18`	`@Input()`
`19`		`- mdInstall: string = '';`
	`19`	`+ mdInstall = '';`
`20`	`20`
`21`	`21`	`@Input()`
`22`		`- mdHTML: string = '';`
	`22`	`+ mdHTML = '';`
`23`	`23`
`24`	`24`	`@Input()`
`25`		`- mdTS: string = '';`
	`25`	`+ mdTS = '';`
`26`	`26`
`27`	`27`	`@Input()`
`28`		`- mdTSHeading: string = 'TypeScript';`
	`28`	`+ mdTSHeading = 'TypeScript';`
`29`	`29`
`30`	`30`	`@Input()`
`31`		`- mdTSHigh: string = '';`
	`31`	`+ mdTSHigh = '';`
`32`	`32`
`33`	`33`	`@Input()`
`34`		`- mdTSHighHeading: string = '';`
	`34`	`+ mdTSHighHeading = '';`
`35`	`35`
`36`	`36`	`@Input()`
`37`	`37`	`template: TemplateRef<any> = null;`
`38`	`38`
	`39`	`+ scrollToElement($elem): void {`
	`40`	`+ $elem.scrollIntoView({behavior: 'smooth', block: 'start', inline: 'nearest'});`
	`41`	`+ }`
	`42`	`+`
`39`	`43`	`}`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 131029e

File tree

2 files changed

2 files changed

`‎demo/src/app/base-demo/base-demo.component.html‎`

`‎demo/src/app/base-demo/base-demo.component.ts‎`

0 commit comments