-
Couldn't load subscription status.
- Fork 3.2k
docs(playgrounds): update playgrounds to include default package-lock file #4282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
thetaPC
approved these changes
Oct 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
I removed the
package-lockfiles from the Vue and React StackBlitz files in a previous PR because StackBlitz generates this file. However, passing thepackage-lockfile significantly improves the speed ofnpm install, reducing the time needed for the playgrounds to load. It also ensures that dependencies don't update automatically without a PR review, allowing us to better catch dependency regressions.The videos below compare loading the badge playground on production and on this PR. On production, it takes nearly a minute to run
npm installwithout apackage-lockfile, while the playground from this PR's docs link installs in under 10 seconds.I added the v6 Vue & React files back but the other ones don't work on production. Will need to add them as part of #4213.
Production (no
package-lock)without-package-lock.mov
This PR (with
package-lock)with-package-lock.mov