-
Couldn't load subscription status.
- Fork 3.2k
docs(v6): Update v6 StackBlitz set up and examples for JavaScript and Angular #4213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v6): Update v6 StackBlitz set up and examples for JavaScript and Angular #4213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor requests
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Note to self/team: we should add the package-lock files here too and make sure it is updated to work with #4282
@brandyscarney are we being blocked by #4282? Seems that we can merge it into this branch now.
@thetaPC I don't think we're blocked we just need to review this still and then plan for the deployment.
Uh oh!
There was an error while loading. Please reload this page.
resolves #4199
Changes
static/code/stackblitz/v6/htmlto allow JavaScript examples to load correctly in StackBlitz.static/code/stackblitz/v6/angularto allow Angular examples to load correctly in StackBlitz.IonicModuleandstandalone: trueto all Angular examples that need anexample.component.tsfile.addIconsmethod in component constructor, creating the component files if they did not exist.versionto string inglobal/Playgroundfiles to match how version is passed in Playgrounds component. I believe it was incorrectly typed but not used in a way that would throw an error. This was necessary to allow a branch for v6 only inloadSourceFileswhere themodeis inserted inmain.ts.addIconsmethod in a new.tsfile.Additional Information
versions.jsonand remove the "v6" entry inversionsArchived.json. This is not in the PR because v6 should not be in the build but will need to be rebuilt and redeployed to Vercel, and the link to the new build updated inversionsArchived.json.https://developer.schoolhas two colons but also seems to no longer exist).