Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs(v6): Update v6 StackBlitz set up and examples for JavaScript and Angular #4213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
soundproofboot wants to merge 55 commits into ionic-team:main
base: main
Choose a base branch
Loading
from soundproofboot:updateV6Stackblitz

Conversation

@soundproofboot
Copy link
Contributor

@soundproofboot soundproofboot commented Jul 25, 2025
edited
Loading

resolves #4199

Changes

  • Update contents of static/code/stackblitz/v6/html to allow JavaScript examples to load correctly in StackBlitz.
  • Update contents of static/code/stackblitz/v6/angular to allow Angular examples to load correctly in StackBlitz.
  • Add IonicModule and standalone: true to all Angular examples that need an example.component.ts file.
  • Update all Angular examples that use Ionicons to use addIcons method in component constructor, creating the component files if they did not exist.
  • Update several other Angular examples on case by case basis to include additional imports like CommonModule, FormsModule, or RoutingModule, etc as needed.
  • Change type of version to string in global/Playground files to match how version is passed in Playgrounds component. I believe it was incorrectly typed but not used in a way that would throw an error. This was necessary to allow a branch for v6 only in loadSourceFiles where the mode is inserted in main.ts.
  • Update JavaScript examples that use Ionicons to use addIcons method in a new .ts file.

Additional Information

  • To build v6 docs, add "v6" to versions.json and remove the "v6" entry in versionsArchived.json. This is not in the PR because v6 should not be in the build but will need to be rebuilt and redeployed to Vercel, and the link to the new build updated in versionsArchived.json.
  • I also found I needed to fix a typo in version-v6/developer-resources/books.md to allow the build. (The link to https://developer.school has two colons but also seems to no longer exist).

Copy link
Contributor Author

This should also resolve #3728

inputFix

Screenshot from v6 Angular Filled Inputs StackBlitz on this branch.

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor requests

soundproofboot reacted with thumbs up emoji
soundproofboot and others added 2 commits October 4, 2025 15:52
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Copy link
Member

Note to self/team: we should add the package-lock files here too and make sure it is updated to work with #4282

Copy link
Contributor

thetaPC commented Oct 23, 2025

@brandyscarney are we being blocked by #4282? Seems that we can merge it into this branch now.

Copy link
Member

@thetaPC I don't think we're blocked we just need to review this still and then plan for the deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thetaPC thetaPC thetaPC requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: v6 StackBlitz examples do not load for Angular and Javascript

AltStyle によって変換されたページ (->オリジナル) /