Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Migrate from NAN -> NAPI #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cowboyd wants to merge 14 commits into confluentinc:master
base: master
Choose a base branch
Loading
from cowboyd:master
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add back static setOauthBearerFailure method
  • Loading branch information
cowboyd committed Mar 25, 2025
commit e23e5f26f91ebf7bc7c021b7da7aaa9ae2b65cc0
2 changes: 1 addition & 1 deletion src/connection.h
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,7 +697,7 @@ template <class T> class Connection : public Napi::ObjectWrap<T> {
return env.Null();
}

Napi::Value NodeSetOAuthBearerTokenFailure(const Napi::CallbackInfo &info) {
static Napi::Value NodeSetOAuthBearerTokenFailure(const Napi::CallbackInfo &info) {
Napi::Env env = info.Env();
if (!info[0].IsString()) {
Napi::Error::New(env, "1st parameter must be an error string").ThrowAsJavaScriptException();
Expand Down
47 changes: 22 additions & 25 deletions src/kafka-consumer.cc
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,10 +533,10 @@ void KafkaConsumer::Init(Napi::Env env, Napi::Object exports) {
*/

InstanceMethod("configureCallbacks", &KafkaConsumer::NodeConfigureCallbacks),
/*
* @brief Methods to do with establishing state
*/

/*
* @brief Methods to do with establishing state
*/
InstanceMethod("connect", &KafkaConsumer::NodeConnect),
InstanceMethod("disconnect", &KafkaConsumer::NodeDisconnect),
InstanceMethod("getMetadata", &KafkaConsumer::NodeGetMetadata),
Expand Down Expand Up @@ -565,30 +565,27 @@ void KafkaConsumer::Init(Napi::Env env, Napi::Object exports) {
InstanceMethod("resume", &KafkaConsumer::NodeResume),


/*
* @brief Methods to do with partition assignment / rebalancing
*/

InstanceMethod("committed", &KafkaConsumer::NodeCommitted),
InstanceMethod("position", &KafkaConsumer::NodePosition),
InstanceMethod("assign", &KafkaConsumer::NodeAssign),
InstanceMethod("unassign", &KafkaConsumer::NodeUnassign),
InstanceMethod("incrementalAssign", &KafkaConsumer::NodeIncrementalAssign),
InstanceMethod("incrementalUnassign", &KafkaConsumer::NodeIncrementalUnassign),
InstanceMethod("assignments", &KafkaConsumer::NodeAssignments),
InstanceMethod("assignmentLost", &KafkaConsumer::NodeAssignmentLost),
InstanceMethod("rebalanceProtocol", &KafkaConsumer::NodeRebalanceProtocol),

InstanceMethod("commit", &KafkaConsumer::NodeCommit),
InstanceMethod("commitSync", &KafkaConsumer::NodeCommitSync),
InstanceMethod("commitCb", &KafkaConsumer::NodeCommitCb),
InstanceMethod("offsetsStore", &KafkaConsumer::NodeOffsetsStore),
InstanceMethod("offsetsStoreSingle", &KafkaConsumer::NodeOffsetsStoreSingle),
});
/*
* @brief Methods to do with partition assignment / rebalancing
*/

InstanceMethod("committed", &KafkaConsumer::NodeCommitted),
InstanceMethod("position", &KafkaConsumer::NodePosition),
InstanceMethod("assign", &KafkaConsumer::NodeAssign),
InstanceMethod("unassign", &KafkaConsumer::NodeUnassign),
InstanceMethod("incrementalAssign", &KafkaConsumer::NodeIncrementalAssign),
InstanceMethod("incrementalUnassign", &KafkaConsumer::NodeIncrementalUnassign),
InstanceMethod("assignments", &KafkaConsumer::NodeAssignments),
InstanceMethod("assignmentLost", &KafkaConsumer::NodeAssignmentLost),
InstanceMethod("rebalanceProtocol", &KafkaConsumer::NodeRebalanceProtocol),

InstanceMethod("commit", &KafkaConsumer::NodeCommit),
InstanceMethod("commitSync", &KafkaConsumer::NodeCommitSync),
InstanceMethod("commitCb", &KafkaConsumer::NodeCommitCb),
InstanceMethod("offsetsStore", &KafkaConsumer::NodeOffsetsStore),
InstanceMethod("offsetsStoreSingle", &KafkaConsumer::NodeOffsetsStoreSingle),
});

// Napi::SetPrototypeMethod(tpl, "setOAuthBearerTokenFailure",
// NodeSetOAuthBearerTokenFailure);


constructor.Reset((tpl->GetFunction(Napi::GetCurrentContext()))
Expand Down

AltStyle によって変換されたページ (->オリジナル) /