Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Migrate from NAN -> NAPI #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cowboyd wants to merge 14 commits into confluentinc:master
base: master
Choose a base branch
Loading
from cowboyd:master
Draft

Migrate from NAN -> NAPI #281

cowboyd wants to merge 14 commits into confluentinc:master from cowboyd:master

Conversation

@cowboyd
Copy link

@cowboyd cowboyd commented Mar 27, 2025 •
edited
Loading

What

N-API is a forward ABI compatible API that is supported by Node, Deno, and Bun. By using N-API instead of NAN, @confluent/kafka-javascript will be able to run on all those runtimes as well as any other runtime that comes along that supports N-API.

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

References

JIRA:

Test & Review

Open questions / Follow-ups

HamzaKhalaf, jalamprea, shumstra, sk-, and pwuexec reacted with thumbs up emoji
Copy link
Contributor

milindl commented Apr 1, 2025

Hey @cowboyd, thanks for the PR!
I've not tested it yet, but eventually replacing NAN with N-API makes sense. We'll probably do this with a major version release though, not immediately, I'll discuss this internally.

Copy link
Author

cowboyd commented Apr 2, 2025

@milindl Thanks! I'm sure that it's broken in a number of ways, but my goal was to get most of the grunt work out of the way. I'd be happy to help you all push further with this as I think it would be killer to get this working on Deno and Bun.

Let me know!
jalamprea reacted with heart emoji

Copy link

tmm1 commented Oct 12, 2025

Would be really useful to have bun support!
mkatrenik and krystianity reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /