Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add post-install test to make sure installation works on all supported platforms #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milindl merged 15 commits into master from dev_post_install_tests
Jan 20, 2025

Conversation

@milindl
Copy link
Contributor

@milindl milindl commented Jan 3, 2025

Runs:

  1. Using 1.0.0: https://semaphore.ci.confluent.io/workflows/d1ac617e-de17-4c2a-8c47-46bd9ec13e0f?pipeline_id=63aaefbd-6631-4e7a-89b8-9c4d441a2685 (as expected, all the ubuntu 20.04/debian bullseye installations fail). Additionally, the rockylinux/almalinux 8 installations fail (not supported platforms), please ignore those and windows failures (some minor mistake in powershell syntax).
  2. Using 0.5.2: https://semaphore.ci.confluent.io/workflows/05e0049f-b893-4c5b-8402-fa7bbf35206f?pipeline_id=a37f34f4-4d8f-429d-8610-9d37615644b4 (as expected node v23 installations fail as we released it with 1.0.0). Additionally, the rockylinux/almalinux 8 installations fail (not supported platforms), please ignore those.

Once we do a 1.1.0-rcX release, I'll run the post install test one last time to verify it.

Accompanying PR for #228 to prevent issues like #221.

@milindl milindl requested review from a team as code owners January 3, 2025 05:32
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

This comment has been minimized.

- pull_request
- forked_pull_request
- tag
tasks:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have to add this task in service.yml otherwise this will be overwritten as stated in the header

milindl reacted with thumbs up emoji
Comment on lines 1 to 6
# This file is managed by ServiceBot plugin - Semaphore. The content in this file is created using a common
# template and configurations in service.yml.
# Any modifications made to version, name, agent, and global_job_config will be overwritten by the generated
# content in nightly runs. Code changes made to the remaining sections will not be affected.
# For more information, please refer to the page:
# https://confluentinc.atlassian.net/wiki/spaces/Foundations/pages/2871296194/Add+SemaphoreCI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file won't be managed by ServiceBot plugin, only project.yml should be, you can remove this comment.

Suggested change
# This file is managed by ServiceBot plugin - Semaphore. The content in this file is created using a common
# template and configurations in service.yml.
# Any modifications made to version, name, agent, and global_job_config will be overwritten by the generated
# content in nightly runs. Code changes made to the remaining sections will not be affected.
# For more information, please refer to the page:
# https://confluentinc.atlassian.net/wiki/spaces/Foundations/pages/2871296194/Add+SemaphoreCI

milindl reacted with thumbs up emoji
Copy link

Passed

Analysis Details

0 Issues

Coverage and Duplications

  • Coverage No coverage information (70.00% Estimated after merge)
  • Duplications No duplication information (3.60% Estimated after merge)

Project ID: confluent-kafka-javascript

View in SonarQube

Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@milindl milindl merged commit f5c907b into master Jan 20, 2025
2 checks passed
@milindl milindl deleted the dev_post_install_tests branch January 20, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emasab emasab emasab approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /