Commit f99db41

committed

Address review comments

1 parent d9a9690 commit f99db41Copy full SHA for f99db41

File tree

+10

-16

lines changed

+10

-16

lines changed

Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,3 @@`
`1`		`-# This file is managed by ServiceBot plugin - Semaphore. The content in this file is created using a common`
`2`		`-# template and configurations in service.yml.`
`3`		`-# Any modifications made to version, name, agent, and global_job_config will be overwritten by the generated`
`4`		`-# content in nightly runs. Code changes made to the remaining sections will not be affected.`
`5`		`-# For more information, please refer to the page:`
`6`		`-# https://confluentinc.atlassian.net/wiki/spaces/Foundations/pages/2871296194/Add+SemaphoreCI`
`7`	`1`	`version: v1.0`
`8`	`2`	`name: post-install`
`9`	`3`	`agent:`

Lines changed: 0 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -42,13 +42,3 @@ spec:`
`42`	`42`	`- pull_request`
`43`	`43`	`- forked_pull_request`
`44`	`44`	`- tag`
`45`		`- tasks:`
`46`		`- - name: post-install`
`47`		`- scheduled: False`
`48`		`- branch: "master"`
`49`		`- pipeline_file: .semaphore/post_install.yml`
`50`		`- parameters:`
`51`		`- - name: LIBRARY_VERSION`
`52`		`- required: True`
`53`		`- description: "Which library version to install."`
`54`		`- default_value: "latest"`

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,16 @@ codeowners:`
`10`	`10`	`enable: true`
`11`	`11`	`semaphore:`
`12`	`12`	`enable: true`
	`13`	`+ tasks:`
	`14`	`+ - name: post-install`
	`15`	`+ scheduled: false`
	`16`	`+ branch: "master"`
	`17`	`+ pipeline_file: .semaphore/post_install.yml`
	`18`	`+ parameters:`
	`19`	`+ - name: LIBRARY_VERSION`
	`20`	`+ required: true`
	`21`	`+ description: "Which library version to install."`
	`22`	`+ default_value: "latest"`
`13`	`23`	`sonarqube:`
`14`	`24`	`enable: true`
`15`	`25`	`coverage_reports:`

Comments

(0)