-
Couldn't load subscription status.
- Fork 56
fix(auth): allows matching of mixed-case usernames #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bufferoverflow
merged 2 commits into
bufferoverflow:master
from
GFWagnitz:GFWagnitz-patch-1
Dec 10, 2019
Merged
fix(auth): allows matching of mixed-case usernames #103
bufferoverflow
merged 2 commits into
bufferoverflow:master
from
GFWagnitz:GFWagnitz-patch-1
Dec 10, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Telokis
commented
Dec 2, 2019
Shouldn't user be lowerCased as well?
@GFWagnitz
GFWagnitz
changed the title
(削除) Allows matching of mixed-case usernames (削除ここまで)
(追記) fix(auth): allows matching of mixed-case usernames (追記ここまで)
Dec 2, 2019
@GFWagnitz
GFWagnitz
changed the title
(削除) Allows matching of mixed-case usernames (削除ここまで)
(追記) fix(auth): allows matching of mixed-case usernames (追記ここまで)
Dec 2, 2019
Allow inserting the lowercase version of the Gitlab username, since it's accepted by the Gitlab API
@GFWagnitz
GFWagnitz
force-pushed
the
GFWagnitz-patch-1
branch
from
December 2, 2019 18:00
e04d0af to
82b7d1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20
Allow inserting the lowercase version of the Gitlab username, since it's accepted by the Gitlab API.
GitLab will now return a user through case-agnostic matching.
Based on #96