Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: simplify board and port handling #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kittaakos wants to merge 3 commits into arduino:main from kittaakos:#1319
Closed

Conversation

@kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Jul 21, 2023 •
edited
Loading

This PR has been replaced by #2165.

(削除) 🚧 Work in progress but in a previewable state (削除ここまで)

(削除) See the Beta Testing Guide for the tester builds. The builds are not signed. See here, how to start the app on macOS. (削除ここまで)

Motivation

(削除) The rewrite of the board and port handling in IDE2. The basic idea is to avoid trying to do port change detection on the IDE2 side (frontend) but rely on the CLI's new API: arduino/arduino-cli#2253. (削除ここまで)

(削除) ### Change description (削除ここまで)

(削除) ### Other information (削除ここまで)

(削除) Closes #1319 (削除ここまで)
(削除) Ref #2143 (削除ここまで)
(削除) Ref #2158 (削除ここまで)

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jul 21, 2023
@kittaakos kittaakos self-assigned this Jul 21, 2023
Copy link
Contributor Author

kittaakos commented Jul 21, 2023 •
edited
Loading

@kittaakos kittaakos force-pushed the #1319 branch 2 times, most recently from 8e66de6 to 12a3d69 Compare July 26, 2023 09:14
kittaakos pushed a commit to kittaakos/arduino-ide that referenced this pull request Jul 26, 2023 
when platform is not installed
Ref: arduino#2149 (comment)
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos force-pushed the #1319 branch 2 times, most recently from 498c7e0 to d2a6f38 Compare July 28, 2023 14:55
@kittaakos kittaakos force-pushed the #1319 branch 2 times, most recently from 9cafe95 to 1bf6fae Compare August 2, 2023 17:24
@kittaakos kittaakos added topic: CLI Related to Arduino CLI type: imperfection Perceived defect in any part of project labels Aug 2, 2023
Akos Kitta added 3 commits August 3, 2023 15:16 
Closes arduino#1319
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
it's unavailable on macOS arm64 (YePpHa/node-protoc#9) and the API
generation is a manual process: 0942ef6
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
To workaround the React-based widget lifecycle issue:
eclipse-theia/theia#12093.
The dialog constructor is called once, hence the default `toDispose`
listener will execute only once per app lifecycle. The default dialog
close behavior (from Theia) will dispose the widget. On dialog reopen,
the constructor won't be called again, as the dialog is injected as
a singleton, but the React component has been unmounted on dialog
dispose. Hence, they will be recreated. The `componentDidMount`
method will be called, but the `componentWillUnmount` is not called
anymore. The dialog is already disposed. It leads to a resource leak.
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Copy link
Contributor Author

kittaakos commented Aug 7, 2023 •
edited by per1234
Loading

Duplicate of #2165.

@kittaakos kittaakos added the conclusion: duplicate Has already been submitted label Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davegarthsimpson davegarthsimpson Awaiting requested review from davegarthsimpson

Labels

conclusion: duplicate Has already been submitted topic: CLI Related to Arduino CLI topic: code Related to content of the project itself type: enhancement Proposed improvement type: imperfection Perceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Simplify board and port handling

1 participant

AltStyle によって変換されたページ (->オリジナル) /