-
-
Notifications
You must be signed in to change notification settings - Fork 512
#1366 Buffer events from BoardListWatchResponse
#1379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kittaakos
kittaakos
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
labels
Sep 1, 2022
per1234
per1234
requested changes
Sep 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 tasks
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos
kittaakos
force-pushed
the
#1366
branch
from
January 12, 2023 07:50
417d95f to
296d59b
Compare
Is part of #2149. Closing as a duplicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Hopefully, the board reconnecting issue is fixed for the
teensyportprotocol.Change description
DetectedPort'add'/'remove'events retrieved from theBoardListWatchResponsees to calculate a correctAttachedBoardsChangeEventfor the IDE2 frontend. If a board was detected to be removed and added in a short period, the discovery service would treat the events as a NOOP.InitRequest) the gRPC core client after the library/platform index updates. This will ensure that already discovered boards/ports won't be re-discovered. The force stop/start guard can be removed as [breaking] daemon: Fix concurrency and streamline access to PackageManager arduino-cli#1828 solved it on the CLI side, so no external guard is required from IDE2.Other information
Closes #1366
Reviewer checklist