-
-
Notifications
You must be signed in to change notification settings - Fork 511
feat: removed non-official themes from the settings dialog #1994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a90a6c7 to
cd43a75
Compare
6192e5a to
d3300ea
Compare
cd43a75 to
a431456
Compare
d3300ea to
2e19646
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users must cancel the Settings dialog or use a command or the advanced settings to select custom, unofficial themes.
Although this is an excellent approach to migrating people away from the deprecated built-in Theia themes (#1283), it harms the user experience when using manually installed themes. It was decided that manual installation of theme extensions will be officially supported (though of course Arduino does not maintain or provide support for the individual 3rd party themes themselves). So we do need to give consideration to that use case.
Would it be possible to apply this behavior (only showing the theme in the "Theme" menu of the "Preferences" dialog if already selected) exclusively to the deprecated built-in Theia themes rather than applying it to the manually installed theme extensions in ~/.arduinoIDE/plugins as well (as is currently done by the PR)? Since it is an officially supported use case, I think the user should be able to select a manually installed 3rd party or custom theme from the "Preferences" dialog (as is the behavior in Arduino IDE 1.x).
Closes #1851 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
2e19646 to
d5947de
Compare
Thank you for the review. I made the requested changes, and the build is running.
Instead of updating the original description of this PR and replacing the screencasts, this section shows the differences between the latest review.
- User-installed (VSIX) themes are always visible in the Settings dialog theme dropdown.
- User-installed theme labels have the
(user)suffix. - If the
currentThemeis either Light (Theia) or Dark (Theia), it will be visible from the dropdown with the(deprecated)suffix. - The themes in the
<select>dictates the following ordering:- Light,
- Dark,
- Hight Contrast,
- User-installed themes grouped by
light,dark, andhctype. If the type equals, sorting is done by the theme label, - Deprecated theme comes last:
Screen Shot 2023年04月14日 at 11 04 27
1283.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Akos!
Closes #1283 Ref eclipse-theia/theia#11151 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
d5947de to
417c2b7
Compare
With the most recent changes, the themes are grouped by built-in, user, and deprecated groups. All the sorting and the behavior must be the same.
1283_separator.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks!
Uh oh!
There was an error while loading. Please reload this page.
(削除) ## Depends on #1988 (削除ここまで)✅Motivation
This PR updates the behavior or the theme
<select>in the Settings dialog and makes it overall easier to "install" and use custom (VS Code extension-based) themes in IDE2.Change description
Light,Dark, andHigh Contrastthemes in the Settings dialog.1283_01.mp4
Preferences: Color Themecommand contributed by Theia. (Or with the Ctrl/⌘+K Ctrl/⌘+T key-chord.) Experienced users should use this command to list and select unofficial themes. The quick-pick theme items show the fully qualified names of the Arduino themes to follow the naming convention among the VS Code extension-based themes. This PR does not change the behavior of theworkbench.colorThemepreference.1283_02.mp4
Preferences: Color Themecommand:<username>is your Windows username)XDG_CONFIG_HOMEis not supported Theia apps: option to respect each operating system standards when chosing their user-levelconfig folderpath eclipse-theia/theia#1518 )1283_03.mp4
Unofficial - ${THEME_NAME}as the<select>label.1283_04.mp4
Unofficial - ${THEME_NAME}. When you unselect the unofficial<select>label, it won't be possible to select it again. Users must cancel the Settings dialog or use a command or the advanced settings to select custom, unofficial themes.1283_05.mp4
1283_06.mp4
Other information
Closes #1283
Closes #1851
Reviewer checklist