Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit a431456

Browse files
author
Akos Kitta
committed
fix: update themeId settings after theme change
In Theia, the theme ID is not always in sync with the persisted `workbench.colorTheme` preference value. For example, one can preview a theme with the `CtrlCmd+K` + `CtrlCmd+T` key chords. On quick pick selection change events, the theme changes, but the change is persisted only on accept (user presses `Enter`). IDE2 has its own way of showing and managing different settings in the UI. When the theme is changed from outside of the IDE2's UI, the model could get out of sync. This PR ensures that on `workbench.colorTheme` preference change, IDE2's settings model is synchronized with persisted Theia preferences. Closes #1987 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
1 parent ab5c63c commit a431456

File tree

1 file changed

+11
-0
lines changed
  • arduino-ide-extension/src/browser/dialogs/settings

1 file changed

+11
-0
lines changed

‎arduino-ide-extension/src/browser/dialogs/settings/settings.ts‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,17 @@ export class SettingsService {
123123
this._settings = deepClone(settings);
124124
this.ready.resolve();
125125
});
126+
this.preferenceService.onPreferenceChanged(async (event) => {
127+
await this.ready.promise;
128+
const { preferenceName, newValue } = event;
129+
if (
130+
preferenceName === 'workbench.colorTheme' &&
131+
typeof newValue === 'string' &&
132+
this._settings.themeId !== newValue
133+
) {
134+
this.reset();
135+
}
136+
});
126137
}
127138

128139
protected async loadSettings(): Promise<Settings> {

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /