Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add dismissible banner shortcode #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manoj9788 merged 1 commit into dev from dj-add-dismissible-banner-and-cve-2021-45105
Dec 22, 2021

Conversation

@ddavison
Copy link
Member

@ddavison ddavison commented Dec 21, 2021 •
edited
Loading

Description

  • Refactor old dismissible banner to be a shortcode for Hugo.
  • Add CVE-2021-45105 vulnerability banner

Motivation and Context

Noting the Selenium software is not affected by CVE-2021-45105 .

rel: #897

Screenshot

Screen Shot 2021年12月21日 at 16 07 09

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • [-] Improved translation
  • [-] Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@ddavison ddavison mentioned this pull request Dec 21, 2021
6 tasks
Copy link

netlify bot commented Dec 21, 2021

✔️ Deploy Preview for jovial-austin-42fe02 ready!

🔨 Explore the source changes: 5b917c6

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-austin-42fe02/deploys/61c241b479251400075c89f7

😎 Browse the preview: https://deploy-preview-898--jovial-austin-42fe02.netlify.app

Copy link
Contributor

mdmintz commented Dec 21, 2021

Copy link
Member Author

@manoj9788 - would you mind reviewing? 🙏

@ddavison ddavison added the enhancement New feature or request label Dec 21, 2021
Copy link
Contributor

mdmintz commented Dec 21, 2021

I'm not an authorized reviewer, but I approve your changes.
ddavison reacted with hooray emoji

Copy link
Member Author

Now that I think about it... was it CVE-2021-44228 ?

Copy link
Contributor

mdmintz commented Dec 21, 2021

Copy link
Contributor

mdmintz commented Dec 21, 2021

Copy link
Contributor

mdmintz commented Dec 21, 2021

Perhaps there were multiple Log4j vulnerabilities in the wild. If there are more than one, perhaps we don't need to mention a specific one at all?

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @ddavison! I started working on that generic banner long time ago and forgot about it. Thanks for fixing it!

BTW I would just say Log4j without mentioning the specific vulnerability. But up to you.

Also, when merging, add [deploy site] to the commit message so the change gets actually deployed.

Copy link
Member

LGTM. Thanks @ddavison good to see you back! :)

@manoj9788 manoj9788 merged commit 4ebe9ab into dev Dec 22, 2021
@manoj9788 manoj9788 deleted the dj-add-dismissible-banner-and-cve-2021-45105 branch December 22, 2021 04:00
selenium-ci added a commit that referenced this pull request Dec 22, 2021 
Add log4j vulnerability banner [deploy site] 4ebe9ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manoj9788 manoj9788 manoj9788 approved these changes

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /