-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Selenium does not use log4j #897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Selenium does not use log4j
✔️ Deploy Preview for jovial-austin-42fe02 ready!
🔨 Explore the source changes: 0c0148a
🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-austin-42fe02/deploys/61c22fc8088a730007ab2333
😎 Browse the preview: https://deploy-preview-897--jovial-austin-42fe02.netlify.app/
I'm not sure it's worth noting what Selenium does not use. I anticipate if we start with this, we'll have a list of all of the software that we do not use that has a major exploit found.
Could you maybe provide more motivation and context? 🙏
@ddavison This is the context:
@ddavison This is the context:
Slack___selenium-plc___selenium
I think we should be able to use the dismissible banner for this instance 🤔
I think this would be better than a blurb on the header. What do you think?
@ddavison Based on the code when the banner was last used (ebcafc8) the folder structure has changed significantly (there's no more site_source_files directory) and so I would only be guessing the new structure that you'd want for that, and that would likely involve a lot of back-and-forth PR questions and comments like this. I picked a reasonable alternative (the bold text is still noticeable) and since I imagine that this special message will only be up for about a month (at which point all major Selenium users concerned about Log4j would already understand that Selenium does not use it) then the styling of the message isn't too significant. After-all, this is a temporary message to begin with.
@ddavison Based on the code when the banner was last used (ebcafc8) the folder structure has changed significantly (there's no more
site_source_filesdirectory) and so I would only be guessing the new structure that you'd want for that, and that would likely involve a lot of back-and-forth PR questions and comments like this. I picked a reasonable alternative (the bold text is still noticeable) and since I imagine that this special message will only be up for about a month (at which point all major Selenium users concerned about Log4j would already understand that Selenium does not use it) then the styling of the message isn't too significant. After-all, this is a temporary message to begin with.
Screen Shot 2021年12月21日 at 15 59 19
Yeah, looks like we should create a dismissible-banner shortcode. I have a local WIP I can upload.
@ddavison That works. Looks like you already have the code for the dismissible banner.
@ddavison That works. Looks like you already have the code for the dismissible banner.
Yeah, the code was already there, just had to adapt it quickly to Hugo 🙃 . You're simple solution worked perfectly! This is just a more long-term solution that enables other things like this in the future 🙏
Would you review #898 ?
Closing this in favor of #898
Selenium does not use log4j
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Selenium does not use log4j
Motivation and Context
Selenium does not use log4j
Types of changes
Checklist