-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add grid 4 section #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grid 4 section #461
Conversation
Thanks to @manoj9788 for the new image. 🙏
@diemol @harsha509 please take a look. This is the first draft of the new grid 4 section. We can iterate with new stuff in multiple PRs.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove '4' here. While i read it makes me a bit confusion like Grid for nodes and later i get it as Grid 4 as this document is for Grid 4. As we are already mentioning Selenium Grid 4 in title, Can we simply say Grid nodes/ registered nodes ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same changes needed for all translated pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the components of Grid4 is different from legacy grid ? If not we have introduce Grid 4 with in legacy grid document.
We will end up having duplicate documents for components of grid and purposes and functionalities if there are no changes from previous.
@diemol Can you please suggest on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @raju249 ,
Thanks for the PR.
Also very thanks on taking time to translate few pages in respective languages.
I've requested for few changes, can you please look into it.
Regards,
Harsha.
932fe2e to
57ffd80
Compare
Thanks @harsha509 for the review.
I have made the other changes, awaiting @diemol's suggestions for your comment
57ffd80 to
093ec8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is copying the same text from the Grid 3 section. This section should be written again for Grid 4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @diemol yes, I am changing it, I just copied those files. Changing it 👍
The image is based on the one presented at the Grid workshop done during the Selenium Conference. I will update the original image and add it to this PR.
image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the image and will merge this. I'll itereate on the content in the next couple of days since I am working on the Grid workshop content.
Changes will be done in a next iteration
Uh oh!
There was an error while loading. Please reload this page.
Description
The new section looks as below:
grid4-test
Motivation and Context
Types of changes
Checklist