Broken Links #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

harsha509 merged 3 commits into trunk from site_links

Apr 5, 2024

Merged

Broken Links #1612

harsha509 merged 3 commits into trunk from site_links

Apr 5, 2024

Conversation

@titusfortner

Copy link

Member

@titusfortner titusfortner commented Mar 22, 2024 •

edited by qodo-merge-pro bot

Loading

User description

Some links are broken due to incorrect syntax, some links have changed location, some are no longer valid and I've changed them to be marked as code instead of URL to maintain historical reference without indicating a link.

Might be a better way to do it.

Type

documentation, enhancement

Description

Updated broken links across multiple blog posts to be marked as code instead of URLs.
Fixed broken links in blog posts, documentation, and meeting notes.
Corrected references to documentation and APIs in blog posts.
Removed GitHub profile links from meeting notes.

Changes walkthrough

Relevant files

Relevant files
Enhancement	23 files going-atomic-how.md `Update Links and Improve Code Reference Formatting in Blog Post` website_and_docs/content/blog/2010/going-atomic-how.md Updated broken links to Closure compiler and Closure library. Changed references to Selenium 1 and WebDriver `getAttribute` methods to be marked as code instead of URL. +3/-3 going-atomic-why.md `Correct Broken Link Reference in Blog Post` website_and_docs/content/blog/2010/going-atomic-why.md Updated a broken link to `JavascriptExecutor.html` to be marked as code instead of URL. +1/-1 selenium-1-0-2-release-firefox-3-6-and-snow-leopard-support.md `Update Download Link Reference in Blog Post` website_and_docs/content/blog/2010/selenium-1-0-2-release-firefox-3-6-and-snow-leopard-support.md Changed a download link to `selenium-remote-control-1.0.2.zip` to be marked as code instead of URL. +1/-1 selenium-1-0-3-released.md `Update Download Link Reference in Blog Post` website_and_docs/content/blog/2010/selenium-1-0-3-released.md Changed a download link to `selenium-remote-control-1.0.3.zip` to be marked as code instead of URL. +2/-2 selenium-2-0-beta-1-release.md `Correct Documentation References in Blog Post` website_and_docs/content/blog/2010/selenium-2-0-beta-1-release.md Updated several references to Selenium documentation and APIs to be marked as code instead of URLs. +5/-5 selenium-2-0a5-released.md `Update API References in Blog Post` website_and_docs/content/blog/2010/selenium-2-0a5-released.md Updated references to new interfaces and APIs to be marked as code instead of URLs. +2/-2 selenium-2-0a6-released.md `Update API References in Blog Post` website_and_docs/content/blog/2010/selenium-2-0a6-released.md Changed references to HTML5 elements API and FirefoxProfiles to be marked as code instead of URLs. +2/-2 bug-bash.md `Correct Project Reference in Blog Post` website_and_docs/content/blog/2011/bug-bash.md Updated a reference to Selenium project on Google Code to be marked as code instead of URL. +1/-1 selenium-2-0b2-released.md `Update Documentation References in Blog Post` website_and_docs/content/blog/2011/selenium-2-0b2-released.md Updated references to Selenium APIs and documentation to be marked as code instead of URLs. +3/-3 selenium-2-0b3-the-next-gen-browser-release.md `Update Download Link Reference in Blog Post` website_and_docs/content/blog/2011/selenium-2-0b3-the-next-gen-browser-release.md Changed a download link to `android-server-2.0b3.apk` to be marked as code instead of URL. +1/-1 selenium-2-0rc1-the-grid-release.md `Correct API Reference in Blog Post` website_and_docs/content/blog/2011/selenium-2-0rc1-the-grid-release.md Updated references to Advanced User Interactions API to be marked as code instead of URLs. +2/-2 selenium-2-0rc3-the-next-ones-the-big-one-release.md `Update Method References in Blog Post` website_and_docs/content/blog/2011/selenium-2-0rc3-the-next-ones-the-big-one-release.md Updated references to WebElement methods and interfaces to be marked as code instead of URLs. +3/-3 selenium-2-1-released.md `Correct Mailing List Link in Blog Post` website_and_docs/content/blog/2011/selenium-2-1-released.md Updated a mailing list link to be a full URL. +1/-1 selenium-2-2-released.md `Update Documentation Reference in Blog Post` website_and_docs/content/blog/2011/selenium-2-2-released.md Changed a reference to better exceptions documentation to be marked as code instead of URL. +1/-1 selenium-2-3-released.md `Correct Source Tree Reference in Blog Post` website_and_docs/content/blog/2011/selenium-2-3-released.md Updated a reference to the source tree to be marked as code instead of URL. +1/-1 selenium-2-6-released.md `Update Class References in Blog Post` website_and_docs/content/blog/2011/selenium-2-6-released.md Updated references to ExpectedConditions, Wait, and WebDriverWait classes to be marked as code instead of URLs. +2/-2 selenium-2-8-released.md `Update Method Reference in Blog Post` website_and_docs/content/blog/2011/selenium-2-8-released.md Changed a reference to RemoteWebDriver.setFileDetector to be marked as code instead of URL. +1/-1 selenium-joins-the-software-freedom-conservancy.md `Correct Project Reference in Blog Post` website_and_docs/content/blog/2011/selenium-joins-the-software-freedom-conservancy.md Updated a reference to Google Code project to be marked as code instead of URL. +1/-1 a-smattering-of-selenium-90.md `Update Talk Reference in Blog Post` website_and_docs/content/blog/2012/a-smattering-of-selenium-90.md Changed a reference to a talk on concurrency to be marked as code instead of URL. +1/-1 selenium-2-16-released-welcome-to-2012.md `Correct Changelog Reference in Blog Post` website_and_docs/content/blog/2012/selenium-2-16-released-welcome-to-2012.md Updated a reference to the changelog to be marked as code instead of URL. +1/-1 source-control.md `Correct Project Reference in Blog Post` website_and_docs/content/blog/2013/source-control.md Updated a reference to Google Code project to be marked as code instead of URL. +1/-1 faq.en.md `Update Documentation References in FAQ` website_and_docs/content/documentation/legacy/selenium_2/faq.en.md Changed references to JavaScriptExecutor and Alert documentation to be marked as code instead of URLs. +2/-2 joint-03-31.md `Remove GitHub Profile Links from Meeting Notes` website_and_docs/content/meetings/2023/joint-03-31.md Removed GitHub profile links from participant names. +24/-24
Bug fix	11 files selenium-hangout-2-recap.md `Fix Broken Link in Blog Post Recap` website_and_docs/content/blog/2013/selenium-hangout-2-recap.md Corrected a broken link to a previous blog post. +1/-1 announcing-selenium-4.md `Fix Broken Documentation Links in Announcement` website_and_docs/content/blog/2021/announcing-selenium-4.md Corrected broken links to documentation sections on basic authentication, JavaScript exceptions, and mutation observation. +3/-3 selenium-4-beta-1.md `Fix Broken Link to TLC Section in Blog Post` website_and_docs/content/blog/2021/selenium-4-beta-1.md Corrected a broken link to the TLC section. +1/-1 selenium_manager.en.md `Fix Broken Link to GitHub Actions Workflow` website_and_docs/content/documentation/selenium_manager.en.md Corrected a broken link to the GitHub Actions workflow. +1/-1 selenium_manager.ja.md `Fix Broken Link to GitHub Actions Workflow` website_and_docs/content/documentation/selenium_manager.ja.md Corrected a broken link to the GitHub Actions workflow. +1/-1 selenium_manager.pt-br.md `Fix Broken Link to GitHub Actions Workflow` website_and_docs/content/documentation/selenium_manager.pt-br.md Corrected a broken link to the GitHub Actions workflow. +1/-1 selenium_manager.zh-cn.md `Fix Broken Link to GitHub Actions Workflow` website_and_docs/content/documentation/selenium_manager.zh-cn.md Corrected a broken link to the GitHub Actions workflow. +1/-1 remote_webdriver.en.md `Fix Broken Link to Browser Documentation` website_and_docs/content/documentation/webdriver/drivers/remote_webdriver.en.md Corrected a broken link to the browser documentation. +1/-1 remote_webdriver.ja.md `Fix Broken Link to Browser Documentation` website_and_docs/content/documentation/webdriver/drivers/remote_webdriver.ja.md Corrected a broken link to the browser documentation. +1/-1 remote_webdriver.pt-br.md `Fix Broken Link to Browser Documentation` website_and_docs/content/documentation/webdriver/drivers/remote_webdriver.pt-br.md Corrected a broken link to the browser documentation. +1/-1 remote_webdriver.zh-cn.md `Fix Broken Link to Browser Documentation` website_and_docs/content/documentation/webdriver/drivers/remote_webdriver.zh-cn.md Corrected a broken link to the browser documentation. +1/-1

Enhancement

23 files

going-atomic-how.md

Update Links and Improve Code Reference Formatting in Blog Post

website_and_docs/content/blog/2010/going-atomic-how.md

Updated broken links to Closure compiler and Closure library.

Changed references to Selenium 1 and WebDriver getAttribute methods to
be marked as code instead of URL.

+3/-3

going-atomic-why.md

Correct Broken Link Reference in Blog Post

website_and_docs/content/blog/2010/going-atomic-why.md

Updated a broken link to JavascriptExecutor.html to be marked as code
instead of URL.

+1/-1

selenium-1-0-2-release-firefox-3-6-and-snow-leopard-support.md

Update Download Link Reference in Blog Post

website_and_docs/content/blog/2010/selenium-1-0-2-release-firefox-3-6-and-snow-leopard-support.md

Changed a download link to selenium-remote-control-1.0.2.zip to be
marked as code instead of URL.

+1/-1

selenium-1-0-3-released.md

Update Download Link Reference in Blog Post

website_and_docs/content/blog/2010/selenium-1-0-3-released.md

Changed a download link to selenium-remote-control-1.0.3.zip to be
marked as code instead of URL.

+2/-2

selenium-2-0-beta-1-release.md

Correct Documentation References in Blog Post

website_and_docs/content/blog/2010/selenium-2-0-beta-1-release.md

Updated several references to Selenium documentation and APIs to be
marked as code instead of URLs.

+5/-5

selenium-2-0a5-released.md

Update API References in Blog Post

website_and_docs/content/blog/2010/selenium-2-0a5-released.md

Updated references to new interfaces and APIs to be marked as code
instead of URLs.

+2/-2

selenium-2-0a6-released.md

Update API References in Blog Post

website_and_docs/content/blog/2010/selenium-2-0a6-released.md

Changed references to HTML5 elements API and FirefoxProfiles to be
marked as code instead of URLs.

+2/-2

bug-bash.md

Correct Project Reference in Blog Post

website_and_docs/content/blog/2011/bug-bash.md

Updated a reference to Selenium project on Google Code to be marked as
code instead of URL.

+1/-1

selenium-2-0b2-released.md

Update Documentation References in Blog Post

website_and_docs/content/blog/2011/selenium-2-0b2-released.md

Updated references to Selenium APIs and documentation to be marked as
code instead of URLs.

+3/-3

selenium-2-0b3-the-next-gen-browser-release.md

Update Download Link Reference in Blog Post

website_and_docs/content/blog/2011/selenium-2-0b3-the-next-gen-browser-release.md

Changed a download link to android-server-2.0b3.apk to be marked as
code instead of URL.

+1/-1

selenium-2-0rc1-the-grid-release.md

Correct API Reference in Blog Post

website_and_docs/content/blog/2011/selenium-2-0rc1-the-grid-release.md

Updated references to Advanced User Interactions API to be marked as
code instead of URLs.

+2/-2

selenium-2-0rc3-the-next-ones-the-big-one-release.md

Update Method References in Blog Post

website_and_docs/content/blog/2011/selenium-2-0rc3-the-next-ones-the-big-one-release.md

Updated references to WebElement methods and interfaces to be marked
as code instead of URLs.

+3/-3

selenium-2-1-released.md

Correct Mailing List Link in Blog Post

website_and_docs/content/blog/2011/selenium-2-1-released.md

Updated a mailing list link to be a full URL.

+1/-1

selenium-2-2-released.md

Update Documentation Reference in Blog Post

website_and_docs/content/blog/2011/selenium-2-2-released.md

Changed a reference to better exceptions documentation to be marked as
code instead of URL.

+1/-1

selenium-2-3-released.md

Correct Source Tree Reference in Blog Post

website_and_docs/content/blog/2011/selenium-2-3-released.md

Updated a reference to the source tree to be marked as code instead of
URL.

+1/-1

selenium-2-6-released.md

Update Class References in Blog Post

website_and_docs/content/blog/2011/selenium-2-6-released.md

Updated references to ExpectedConditions, Wait, and WebDriverWait
classes to be marked as code instead of URLs.

+2/-2

selenium-2-8-released.md

Update Method Reference in Blog Post

website_and_docs/content/blog/2011/selenium-2-8-released.md

Changed a reference to RemoteWebDriver.setFileDetector to be marked as
code instead of URL.

+1/-1

selenium-joins-the-software-freedom-conservancy.md

Correct Project Reference in Blog Post

website_and_docs/content/blog/2011/selenium-joins-the-software-freedom-conservancy.md

Updated a reference to Google Code project to be marked as code
instead of URL.

+1/-1

a-smattering-of-selenium-90.md

Update Talk Reference in Blog Post

website_and_docs/content/blog/2012/a-smattering-of-selenium-90.md

Changed a reference to a talk on concurrency to be marked as code
instead of URL.

+1/-1

selenium-2-16-released-welcome-to-2012.md

Correct Changelog Reference in Blog Post

website_and_docs/content/blog/2012/selenium-2-16-released-welcome-to-2012.md

Updated a reference to the changelog to be marked as code instead of
URL.

+1/-1

source-control.md

Correct Project Reference in Blog Post

website_and_docs/content/blog/2013/source-control.md

Updated a reference to Google Code project to be marked as code
instead of URL.

+1/-1

faq.en.md

Update Documentation References in FAQ

website_and_docs/content/documentation/legacy/selenium_2/faq.en.md

Changed references to JavaScriptExecutor and Alert documentation to be
marked as code instead of URLs.

+2/-2

joint-03-31.md

Remove GitHub Profile Links from Meeting Notes

website_and_docs/content/meetings/2023/joint-03-31.md

Removed GitHub profile links from participant names.

+24/-24

Bug fix

11 files

selenium-hangout-2-recap.md

Fix Broken Link in Blog Post Recap

website_and_docs/content/blog/2013/selenium-hangout-2-recap.md

Corrected a broken link to a previous blog post.

+1/-1

announcing-selenium-4.md

Fix Broken Documentation Links in Announcement

website_and_docs/content/blog/2021/announcing-selenium-4.md

Corrected broken links to documentation sections on basic
authentication, JavaScript exceptions, and mutation observation.

+3/-3

selenium-4-beta-1.md

Fix Broken Link to TLC Section in Blog Post

website_and_docs/content/blog/2021/selenium-4-beta-1.md

Corrected a broken link to the TLC section.

+1/-1

selenium_manager.en.md

Fix Broken Link to GitHub Actions Workflow

website_and_docs/content/documentation/selenium_manager.en.md

Corrected a broken link to the GitHub Actions workflow.

+1/-1

selenium_manager.ja.md

Fix Broken Link to GitHub Actions Workflow

website_and_docs/content/documentation/selenium_manager.ja.md

Corrected a broken link to the GitHub Actions workflow.

+1/-1

selenium_manager.pt-br.md

Fix Broken Link to GitHub Actions Workflow

website_and_docs/content/documentation/selenium_manager.pt-br.md

Corrected a broken link to the GitHub Actions workflow.

+1/-1

selenium_manager.zh-cn.md

Fix Broken Link to GitHub Actions Workflow

website_and_docs/content/documentation/selenium_manager.zh-cn.md

Corrected a broken link to the GitHub Actions workflow.

+1/-1

remote_webdriver.en.md

Fix Broken Link to Browser Documentation

website_and_docs/content/documentation/webdriver/drivers/remote_webdriver.en.md

Corrected a broken link to the browser documentation.

+1/-1

remote_webdriver.ja.md

Fix Broken Link to Browser Documentation

website_and_docs/content/documentation/webdriver/drivers/remote_webdriver.ja.md

Corrected a broken link to the browser documentation.

+1/-1

remote_webdriver.pt-br.md

Fix Broken Link to Browser Documentation

website_and_docs/content/documentation/webdriver/drivers/remote_webdriver.pt-br.md

Corrected a broken link to the browser documentation.

+1/-1

remote_webdriver.zh-cn.md

Fix Broken Link to Browser Documentation

website_and_docs/content/documentation/webdriver/drivers/remote_webdriver.zh-cn.md

Corrected a broken link to the browser documentation.

+1/-1

✨ PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

@titusfortner


 annotate references to googlecode so they are not parsed as valid url

adf3949

this allows us to keep historical reference without broken links

@netlify

Copy link

netlify bot commented Mar 22, 2024 •

edited

Loading

✅ Deploy Preview for selenium-dev ready!

Name	Link
🔨 Latest commit	`9387d5f`
🔍 Latest deploy log	https://app.netlify.com/sites/selenium-dev/deploys/660fcd9ff3e6620008f54445
😎 Deploy Preview	https://deploy-preview-1612--selenium-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... QR Code Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@qodo-merge-pro qodo-merge-pro bot added documentation enhancement labels

Mar 22, 2024

@qodo-merge-pro

Copy link

Contributor

qodo-merge-pro bot commented Mar 22, 2024

PR Description updated to latest commit (280b026)

Copy walkthrough table to "Files Changed" Tab

@qodo-merge-pro qodo-merge-pro bot added the Review effort [1-5]: 1 label

Mar 22, 2024

@qodo-merge-pro

Copy link

Contributor

qodo-merge-pro bot commented Mar 22, 2024

PR Review

⏱️ Estimated effort to review [1-5]

1, because the PR is primarily focused on updating documentation and meeting notes, which are straightforward to review. The changes involve link corrections and formatting adjustments, which are not complex.

🧪 Relevant tests

🔍 Possible issues

🔒 Security concerns

✨ Review tool usage guide:

Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

Utilizing extra instructions

The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.

Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.

Examples for extra instructions:

[pr_reviewer] # /review #
extra_instructions="""
In the 'possible issues' section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

How to enable\disable automation

When you first install PR-Agent app, the default mode for the review tool is:

pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

Auto-labels

The review tool can auto-generate two specific types of labels for a PR:

a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

Extra sub-tools

The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_ticket, require_can_be_split_review, and more.

Auto-approve PRs

By invoking:

/review auto_approve

The tool will automatically approve the PR, and add a comment with the approval.

To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following:

[pr_reviewer]
enable_auto_approval = true

(this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository)

You can also enable auto-approval only if the PR meets certain requirements, such as that the estimated_review_effort is equal or below a certain threshold, by adjusting the flag:

[pr_reviewer]
maximal_review_effort = 5

More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.

/describe: Update the PR title and description based on the contents of the PR.

/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.

/ask <QUESTION>: Ask a question about the PR.

/update_changelog: Update the changelog based on the PR's contents.

/add_docs 💎: Generate docstring for new components introduced in the PR.

/generate_labels 💎: Generate labels for the PR based on the PR's contents.

/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

@qodo-merge-pro

Copy link

Contributor

qodo-merge-pro bot commented Mar 22, 2024 •

edited

Loading

PR Code Suggestions

Category	Suggestions
Security	Replace HTTP links with HTTPS for security. Replace the outdated and potentially insecure HTTP links with HTTPS to ensure the security and integrity of the links provided in the document. website_and_docs/content/blog/2010/going-atomic-how.md [22] -Selenium 1’s getAttribute (`http://selenium.googlecode.com/svn/trunk/docs/api/java/com/thoughtworks/selenium/Selenium.html#getAttribute(java.lang.String)`) method only returns the value of a particular attribute, whereas WebDriver’s getAttribute (`http://selenium.googlecode.com/svn/trunk/docs/api/java/org/openqa/selenium/WebElement.html#getAttribute(java.lang.String`)) method will return the value of either a property or an attribute +Selenium 1’s getAttribute (`https://selenium.googlecode.com/svn/trunk/docs/api/java/com/thoughtworks/selenium/Selenium.html#getAttribute(java.lang.String)`) method only returns the value of a particular attribute, whereas WebDriver’s getAttribute (`https://selenium.googlecode.com/svn/trunk/docs/api/java/org/openqa/selenium/WebElement.html#getAttribute(java.lang.String`)) method will return the value of either a property or an attribute
Enhancement	Correct markdown link syntax for readability and navigation. Correct the syntax of the markdown links to ensure they are properly formatted and clickable. website_and_docs/content/blog/2011/selenium-2-6-released.md [16] -ExpectedConditions (`http://selenium.googlecode.com/svn/trunk/docs/api/java/org/openqa/selenium/support/ui/ExpectedConditions.html) class that supplies many useful criteria +ExpectedConditions ([`http://selenium.googlecode.com/svn/trunk/docs/api/java/org/openqa/selenium/support/ui/ExpectedConditions.html`]) class that supplies many useful criteria
	Convert direct URLs to markdown link format for better readability. Replace the direct URL with a markdown link format for better readability and consistency with the previous format. This will make the document more user-friendly and maintainable. website_and_docs/content/blog/2010/selenium-2-0a6-released.md [19] -* New APIs for dealing with HTML5 elements (`http://selenium.googlecode.com/svn/trunk/docs/api/java/org/openqa/selenium/html5/package-summary.html`) (best implemented, for now, by the mobile webdrivers) +* New APIs for dealing with HTML5 elements [org.openqa.selenium.html5 package summary](http://selenium.googlecode.com/svn/trunk/docs/api/java/org/openqa/selenium/html5/package-summary.html) (best implemented, for now, by the mobile webdrivers)
	Use markdown link format for URLs to improve document readability. Convert the direct URLs to markdown link format to maintain consistency and improve the readability of the document. website_and_docs/content/blog/2011/selenium-2-0b2-released.md [19] -* Added Selenium.getCssCount (`http://selenium.googlecode.com/svn/trunk/docs/api/java/com/thoughtworks/selenium/Selenium.html#getCssCount(java.lang.String)`) to mirror "Selenium.getXpathCount" +* Added Selenium.getCssCount [com.thoughtworks.selenium.Selenium#getCssCount](http://selenium.googlecode.com/svn/trunk/docs/api/java/com/thoughtworks/selenium/Selenium.html#getCssCount(java.lang.String)) to mirror "Selenium.getXpathCount"
	Convert direct URLs to markdown links for consistency. For consistency and readability, convert the direct URL into a markdown link. website_and_docs/content/blog/2010/going-atomic-why.md [28] -Although we have a mechanism available (`http://selenium.googlecode.com/svn/trunk/docs/api/java/org/openqa/selenium/JavascriptExecutor.html`) in every browser for executing JS, it’s wildly inefficient to dump an enormous lump of code on to the JS engine of the browser whenever you want to query the DOM. +Although we have a mechanism available [org.openqa.selenium.JavascriptExecutor](http://selenium.googlecode.com/svn/trunk/docs/api/java/org/openqa/selenium/JavascriptExecutor.html) in every browser for executing JS, it’s wildly inefficient to dump an enormous lump of code on to the JS engine of the browser whenever you want to query the DOM.
	Convert direct URLs to markdown links for improved readability. Replace the direct URL with markdown link format to enhance the document's readability and maintain consistency. website_and_docs/content/documentation/legacy/selenium_2/faq.en.md [38] -As a result, for those browsers that support it, you can execute Javascript by casting the WebDriver instance to a JavascriptExecutor (`http://selenium.googlecode.com/svn/trunk/docs/api/java/org/openqa/selenium/JavascriptExecutor.html`). +As a result, for those browsers that support it, you can execute Javascript by casting the WebDriver instance to a [JavascriptExecutor](http://selenium.googlecode.com/svn/trunk/docs/api/java/org/openqa/selenium/JavascriptExecutor.html).
	Improve link description for better accessibility and context. Consider updating the GitHub Actions workflow link to use a more descriptive text than just "GitHub Actions workflow". This can improve accessibility and provide more context to the reader. website_and_docs/content/documentation/selenium_manager.en.md [172] -Selenium Manager is compiled using a [GitHub Actions workflow](https://github.com/SeleniumHQ/selenium/actions/workflows/ci-rust.yml). +Selenium Manager is compiled using a GitHub Actions workflow, which you can view and download the binaries from [here](https://github.com/SeleniumHQ/selenium/actions/workflows/ci-rust.yml).
	Replace direct download link with a link to the download page for context. Replace the direct link to the downloadable file with a link to the download page or repository to provide context and additional options to the user. website_and_docs/content/blog/2010/selenium-1-0-3-released.md [14] -You can download it now (`http://selenium.googlecode.com/files/selenium-remote-control-1.0.3.zip`). +You can download it from our [releases page](https://github.com/SeleniumHQ/selenium/releases).
Best practice	Use angle brackets for URLs in markdown for correct link parsing. Enclose URLs in markdown links with angle brackets (`<` and `>`) to ensure they are correctly interpreted as links by markdown parsers. website_and_docs/content/blog/2010/selenium-2-0-beta-1-release.md [15] -alerts, prompts and confirms (`http://selenium.googlecode.com/svn/trunk/docs/api/java/org/openqa/selenium/WebDriver.TargetLocator.html#alert()`). +alerts, prompts and confirms (`<http://selenium.googlecode.com/svn/trunk/docs/api/java/org/openqa/selenium/WebDriver.TargetLocator.html#alert()>`).
Best practice	Standardize hyperlink markdown formatting for consistency. Ensure consistency in hyperlink markdown formatting across the document to improve readability and navigation. website_and_docs/content/meetings/2023/joint-03-31.md [82] -[Alex Rodionov]: https://github.com/p0deje/ +[Alex Rodionov](https://github.com/p0deje/)
Maintainability	Update information on deprecated interfaces and methods. Update deprecated methods and interfaces information to reflect current best practices and guide users towards more modern alternatives. website_and_docs/content/blog/2011/selenium-2-0rc3-the-next-ones-the-big-one-release.md [16] -The deprecated RenderedWebElement interface has now been removed. Most of the functionality has been moved to either WebElement (`http://selenium.googlecode.com/svn/trunk/docs/api/java/org/openqa/selenium/WebElement.html`) or to the Actions (`http://selenium.googlecode.com/svn/trunk/docs/api/java/org/openqa/selenium/interactions/Actions.html`) class. +The RenderedWebElement interface has been removed. Its functionality is now available in the WebElement (`http://selenium.googlecode.com/svn/trunk/docs/api/java/org/openqa/selenium/WebElement.html`) and Actions (`http://selenium.googlecode.com/svn/trunk/docs/api/java/org/openqa/selenium/interactions/Actions.html`) classes.
	Update or remove the outdated Google Code link. Update the outdated Google Code link to a more current resource or remove it if it's no longer relevant, as Google Code has been archived. website_and_docs/content/blog/2011/selenium-joins-the-software-freedom-conservancy.md [14] -Development will continue to use Google Code’s (`http://selenium.googlecode.com/`) code hosting and issue tracking. +Development has moved to GitHub, and you can follow our progress on our [GitHub repository](https://github.com/SeleniumHQ/selenium).
	Update SVN link to current documentation or API reference. Replace the direct link to the SVN repository with a link to the corresponding documentation or API reference on a more current platform like GitHub. website_and_docs/content/blog/2011/selenium-2-2-released.md [15] -One thing you might appreciate is better exceptions (`http://selenium.googlecode.com/svn/trunk/docs/api/java/org/openqa/selenium/IllegalLocatorException.html`) being thrown when xpath searches return something other than a web element. +One thing you might appreciate is better exceptions, as detailed in our [API documentation](https://www.selenium.dev/selenium/docs/api/java/org/openqa/selenium/IllegalLocatorException.html).
	Update the Selenium project link to a current website or repository. Update the link to the Selenium project to point to a current and active website or repository, as Google Code has been archived. website_and_docs/content/blog/2011/bug-bash.md [12] -When the Selenium (`http://selenium.googlecode.com/`) and WebDriver projects merged, all those moons ago, we moved the infrastructure from something we hosted to Google Code. +When the Selenium and WebDriver projects merged, we moved the infrastructure to our [GitHub repository](https://github.com/SeleniumHQ/selenium).
Possible issue	Correct URL format for proper accessibility. Correct the URL format by removing the extra parentheses to ensure the link is properly formatted and accessible. website_and_docs/content/documentation/selenium_manager.ja.md [172] -- From the build workflow. Selenium Manager is compiled using a [GitHub Actions workflow](https://github.com/SeleniumHQ/selenium/actions/workflows/ci-rust.yml). This workflow creates binaries for Windows, Linux, and macOS. You can download these binaries from these workflow executions. +- From the build workflow. Selenium Manager is compiled using a GitHub Actions workflow (`https://github.com/SeleniumHQ/selenium/actions/workflows/ci-rust.yml`). This workflow creates binaries for Windows, Linux, and macOS. You can download these binaries from these workflow executions.
Possible issue	Update the outdated and insecure URL to the correct and secure location of the Selenium project's source code. The URL `http://selenium.googlecode.com/` is using the insecure HTTP protocol. Given that Google Code has been shut down and redirects to HTTPS URLs, it's likely that this URL is outdated or incorrect. It's important to verify the current status of the Selenium project's source code hosting and update this URL to a secure and accurate location. If the project is now hosted on GitHub or another platform, provide the correct HTTPS URL to ensure users are directed to the right place without security warnings. website_and_docs/content/blog/2013/source-control.md [17] -Although the canonical source will be on Google Code (`http://selenium.googlecode.com/`), we’re working on setting up a github mirror. We’ll announce the location of that once it’s set up. +Although the canonical source will be on [GitHub](https://github.com/seleniumhq/selenium) (or the current hosting platform), we’re working on setting up additional mirrors. We’ll announce the locations of those once they’re set up.

✨ Improve tool usage guide:

Overview:
The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.
When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:

/improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...

With a configuration file, use the following template:

[pr_code_suggestions]
some_config1=...
some_config2=...

Enabling\disabling automation

When you first install the app, the default mode for the improve tool is:

pr_commands = ["/improve --pr_code_suggestions.summarize=true", ...]

meaning the improve tool will run automatically on every PR, with summarization enabled. Delete this line to disable the tool from running automatically.

Utilizing extra instructions

Extra instructions are very important for the improve tool, since they enable to guide the model to suggestions that are more relevant to the specific needs of the project.

Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify relevant aspects that you want the model to focus on.

Examples for extra instructions:

[pr_code_suggestions] # /improve #
extra_instructions="""
Emphasize the following aspects:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

A note on code suggestions quality

While the current AI for code is getting better and better (GPT-4), it's not flawless. Not all the suggestions will be perfect, and a user should not accept all of them automatically.
Suggestions are not meant to be simplistic. Instead, they aim to give deep feedback and raise questions, ideas and thoughts to the user, who can then use his judgment, experience, and understanding of the code base.
Recommended to use the 'extra_instructions' field to guide the model to suggestions that are more relevant to the specific needs of the project, or use the custom suggestions 💎 tool
With large PRs, best quality will be obtained by using 'improve --extended' mode.

More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.

/describe: Update the PR title and description based on the contents of the PR.

/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.

/ask <QUESTION>: Ask a question about the PR.

/update_changelog: Update the changelog based on the PR's contents.

/add_docs 💎: Generate docstring for new components introduced in the PR.

/generate_labels 💎: Generate labels for the PR based on the PR's contents.

/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the improve usage page for a more comprehensive guide on using this tool.

@titusfortner


 fix broken links

1696a28

@titusfortner titusfortner force-pushed the site_links branch from 280b026 to 1696a28 Compare

March 22, 2024 15:13

@aguspe aguspe mentioned this pull request

Mar 25, 2024

Fix broken link that stops initialization and add one ruby example #1613

Merged

6 tasks

@harsha509


 Merge branch 'trunk' into site_links

9387d5f

harsha509

harsha509 approved these changes

Apr 5, 2024

View reviewed changes

Copy link

Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @titusfortner !

@harsha509 harsha509 merged commit c73064b into trunk

Apr 5, 2024

@harsha509 harsha509 deleted the site_links branch

April 5, 2024 10:24

selenium-ci added a commit that referenced this pull request

Apr 5, 2024

@selenium-ci


 Broken Links ( #1612 )[deploy site]

fb99c35

* annotate references to googlecode so they are not parsed as valid url
this allows us to keep historical reference without broken links
* fix broken links
---------
Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com> c73064b

Labels

documentation enhancement Review effort [1-5]: 1

3 participants

@titusfortner @harsha509

Uh oh!

Broken Links #1612

Broken Links #1612

Uh oh!

Conversation

@titusfortner titusfortner commented Mar 22, 2024 • edited by qodo-merge-pro bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

Type

Description

Changes walkthrough

Uh oh!

netlify bot commented Mar 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for selenium-dev ready!

Uh oh!

qodo-merge-pro bot commented Mar 22, 2024

Uh oh!

qodo-merge-pro bot commented Mar 22, 2024

PR Review

Uh oh!

qodo-merge-pro bot commented Mar 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Code Suggestions

Uh oh!

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

@titusfortner titusfortner commented Mar 22, 2024 •

edited by qodo-merge-pro bot

Loading

netlify bot commented Mar 22, 2024 •

edited

Loading

qodo-merge-pro bot commented Mar 22, 2024 •

edited

Loading