-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix broken link that stops initialization and add one ruby example #1613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
PR Description updated to latest commit (562ae71)
- Copy walkthrough table to "Files Changed" Tab
PR Review
2, because the PR mainly involves documentation updates and a minor version update in a dependency. The changes are straightforward and do not involve complex logic changes or additions.
No
Typo in Title: The title of the Selenium Manager in the English markdown file has been changed incorrectly from "Selenium Manager (Beta)" to "Selenium ManagerBeta)". This is likely a typo and should be corrected.
No
✨ Review tool usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...
With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...
Utilizing extra instructions
The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.
Examples for extra instructions:
[pr_reviewer] # /review #
extra_instructions="""
In the 'possible issues' section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""
Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
How to enable\disable automation
- When you first install PR-Agent app, the default mode for the
reviewtool is:
pr_commands = ["/review", ...]
meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations
Auto-labels
The review tool can auto-generate two specific types of labels for a PR:
- a
possible security issuelabel, that detects possible security issues (enable_review_labels_securityflag) - a
Review effort [1-5]: xlabel, where x is the estimated effort to review the PR (enable_review_labels_effortflag)
Extra sub-tools
The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_ticket, require_can_be_split_review, and more.
Auto-approve PRs
By invoking:
/review auto_approve
The tool will automatically approve the PR, and add a comment with the approval.
To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following:
[pr_reviewer]
enable_auto_approval = true
(this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository)
You can also enable auto-approval only if the PR meets certain requirements, such as that the estimated_review_effort is equal or below a certain threshold, by adjusting the flag:
[pr_reviewer]
maximal_review_effort = 5
More PR-Agent commands
To invoke the PR-Agent, add a comment using one of the following commands:
- /review: Request a review of your Pull Request.
- /describe: Update the PR title and description based on the contents of the PR.
- /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
- /ask <QUESTION>: Ask a question about the PR.
- /update_changelog: Update the changelog based on the PR's contents.
- /add_docs 💎: Generate docstring for new components introduced in the PR.
- /generate_labels 💎: Generate labels for the PR based on the PR's contents.
- /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.
See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.
See the review usage page for a comprehensive guide on using this tool.
PR Code Suggestions
✨ Improve tool usage guide:Overview: With a configuration file, use the following template: Enabling\disabling automationWhen you first install the app, the default mode for the improve tool is: meaning the Utilizing extra instructionsExtra instructions are very important for the Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify relevant aspects that you want the model to focus on. Examples for extra instructions: Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable. A note on code suggestions quality
More PR-Agent commands
See the improve usage page for a more comprehensive guide on using this tool. |
@titusfortner I checked your PR and fixed the same issue #1612 that did not let me build
So once that your PR is merged I will update this branch, and just have the changes to the ruby docs
website_and_docs/content/documentation/webdriver/getting_started/first_script.en.md
Outdated
Show resolved
Hide resolved
Thank you for your review @diemol, let me know if there are more needed changes or anything else I should change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @aguspe!
83402c4 to
885736e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @aguspe!
Uh oh!
There was an error while loading. Please reload this page.
User description
Description
This PR was to add missing ruby examples on the documentation, but when I was setting up I couldn't start the hugo server, so I just fixed the broken links instead
Motivation and Context
I was going through the docs and I noticed that this URL https://www.selenium.dev/documentation/selenium_manager/(https://github.com/SeleniumHQ/selenium/actions/workflows/ci-rust.yml) which is present on this page: https://www.selenium.dev/documentation/selenium_manager/
Was throwing a 404 error, and it was the same error that I had when trying to initialize the Hugo server on my Mac
Built in 4316 ms Error: error building site: render: failed to render pages: render of "page" failed: "/Users/apeque01/Library/Caches/hugo_cache/modules/filecache/modules/pkg/mod/github.com/google/docsy@v0.8.0/layouts/docs/single.html:2:3": execute of template failed: template: docs/single.html:2:3: executing "main" at <.Render>: error calling Render: failed to execute template _default/content.html: "/Users/apeque01/Library/Caches/hugo_cache/modules/filecache/modules/pkg/mod/github.com/google/docsy@v0.8.0/layouts/_default/content.html:10:4": execute of template failed: template: _default/content.html:10:4: executing "_default/content.html" at <.Content>: error calling Content: "/Users/apeque01/Desktop/seleniumhq.github.io/website_and_docs/content/documentation/selenium_manager.pt-br.md:1:1": execute of template failed: template: _default/_markup/render-link.html:1:14: executing "_default/_markup/render-link.html" at <urls.Parse>: error calling Parse: parse "(https://github.com/SeleniumHQ/selenium/actions/workflows/ci-rust.yml)": first path segment in URL cannot contain colonTypes of changes
Checklist
Type
enhancement, documentation
Description
fs-extrapackage version inpackage-lock.json.Changes walkthrough
first_script.rb
Add Execution Instructions to Ruby Scriptexamples/ruby/spec/getting_started/first_script.rb
selenium_manager.en.md
Fix Broken Link and Minor Title Correction in Selenium ManagerDocumentationwebsite_and_docs/content/documentation/selenium_manager.en.md
ManagerBeta)".
selenium_manager.ja.md
Fix Broken Link in Selenium Manager Documentation (Japanese)website_and_docs/content/documentation/selenium_manager.ja.md
selenium_manager.pt-br.md
Fix Broken Link in Selenium Manager Documentation (Portuguese)website_and_docs/content/documentation/selenium_manager.pt-br.md
selenium_manager.zh-cn.md
Fix Broken Link in Selenium Manager Documentation (Chinese)website_and_docs/content/documentation/selenium_manager.zh-cn.md
first_script.en.md
Add Ruby Example for Executing Selenium Scriptswebsite_and_docs/content/documentation/webdriver/getting_started/first_script.en.md
line.
package-lock.json
Update fs-extra Package Versionwebsite_and_docs/package-lock.json
fs-extrapackage from version 11.1.0 to 11.2.0.