-
-
Couldn't load subscription status.
- Fork 1.5k
Change how we do versioning #1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
8297882 to
94e3880
Compare
looks like this is on all pages, not just documentation page, so need to fix that....
18df421 to
99f936d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This opens the door to maintain different versions of the documentation. Do we want that? Do we have the time and people to do that?
I am fine with removing the badges and doing something about it. But I am skeptical about having a version drop down.
- It's dumb to have Legacy stuff in the documentation, we at least should figure out someplace else to put that /somehow/
- Right now we're putting badges on any code with a minimum version of what is needed for it to work. I actually like this, but I've been told it is confusing...
- I do think we should be versioning our code, but it doesn't make sense to do this until we have all of our docs actually updated 😂
It's dumb to have Legacy stuff in the documentation, we at least should figure out someplace else to put that /somehow/
If Legacy is confusing, then why not hide it?
To hide a page or section from the left navigation menu, set toc_hide: true in the front matter.
https://www.docsy.dev/docs/adding-content/navigation/#section-menu
(in case it wasn't obvious, I'm the one who set Legacy to be where it is now, so I'm calling what I did previously dumb).
I'll take a look at hiding it.
Uh oh!
There was an error while loading. Please reload this page.
Description
(削除) in the nav bar (削除ここまで)above breadcrumbsMotivation and Context
(削除) drop down in nav bar is the default Docsy way to do it (削除ここまで)This was going to be the default Docsy way, but it didn't make sense to have versions always displayed in NavBar even when not on documentation page. Also, I customized the toggle so the dropdown gives the version being displayed, not a title hard-coded in the toml fileWhat do you think? Is this better?
Update:
Because we are only translating the documentation, it might make sense to move that to the new place as well?
What do we think? Put it back?