-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Change how we do versioning #1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Draft
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a0eba92
add versions and move legacy into separate directory; english only
titusfortner cd7da0e
remove badge-version in documentation
titusfortner 991fee1
move version toggle from nav bar to above breadcrumbs
titusfortner defa441
move translations to documentation-only pages as well
titusfortner 99f936d
can't have translations outside of docs if the toggle is only in docs
titusfortner e500b12
Merge branch 'trunk' into versions
harsha509 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
move translations to documentation-only pages as well
- Loading branch information
commit defa441567e72157176b9a912fc3bff5d509d07b
There are no files selected for viewing
8 changes: 6 additions & 2 deletions
...d_docs/assets/scss/_version_selector.scss → ...e_and_docs/assets/scss/_docs_toggles.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,14 @@ | ||
| .version-selector a { | ||
| .docs-toggles { | ||
| float: right; | ||
| } | ||
|
|
||
| .docs-toggles a { | ||
| border-bottom: 0px; | ||
| text-align: right; | ||
| font-size: 1.5rem; | ||
| } | ||
|
|
||
| .version-selector ul { | ||
| .docs-toggles ul { | ||
| right: 0 !important; | ||
| left: auto !important; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,4 +10,4 @@ | |
| @import "logo"; | ||
| @import "screen"; | ||
| @import "tabs"; | ||
| @import "version_selector" | ||
| @import "docs_toggles" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 18 additions & 20 deletions
website_and_docs/layouts/partials/navbar-version-selector.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,18 @@ | ||
| <div class="version-selector"> | ||
| <div class="dropdown"> | ||
| <a id="versionDropdownToggle" class="nav-link dropdown-toggle" href="#" role="button" data-bs-toggle="dropdown" aria-haspopup="true" aria-expanded="false"> | ||
| {{- if in .RelPermalink "legacy" -}} | ||
| Legacy | ||
| {{- else -}} | ||
| {{- .Site.Params.version_menu -}} | ||
| {{- end -}} | ||
| </a> | ||
| <ul class="dropdown-menu"> | ||
| {{ $path := "" -}} | ||
| {{ if .Site.Params.version_menu_pagelinks -}} | ||
| {{ $path = .Page.RelPermalink -}} | ||
| {{ end -}} | ||
| {{ range .Site.Params.versions -}} | ||
| <li><a class="dropdown-item" href="{{ .url }}{{ $path }}">{{ .version }}</a></li> | ||
| {{ end -}} | ||
| </ul> | ||
| </div> | ||
| </div> | ||
| <div class="dropdown"> | ||
| <a id="versionDropdownToggle" class="nav-link dropdown-toggle" href="#" role="button" data-bs-toggle="dropdown" aria-haspopup="true" aria-expanded="false"> | ||
| {{- if in .RelPermalink "legacy" -}} | ||
| Legacy | ||
| {{- else -}} | ||
| {{- .Site.Params.version_menu -}} | ||
| {{- end -}} | ||
| </a> | ||
| <ul class="dropdown-menu"> | ||
| {{ $path := "" -}} | ||
| {{ if .Site.Params.version_menu_pagelinks -}} | ||
| {{ $path = .Page.RelPermalink -}} | ||
| {{ end -}} | ||
| {{ range .Site.Params.versions -}} | ||
| <li><a class="dropdown-item" href="{{ .url }}{{ $path }}">{{ .version }}</a></li> | ||
| {{ end -}} | ||
| </ul> | ||
| </div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.