-
-
Notifications
You must be signed in to change notification settings - Fork 536
Custom Type for Unstyled Tooltip #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -439,7 +439,8 @@ class ReactTooltip extends Component { | |
| {'type-warning': this.state.type === 'warning'}, | ||
| {'type-error': this.state.type === 'error'}, | ||
| {'type-info': this.state.type === 'info'}, | ||
| {'type-light': this.state.type === 'light'} | ||
| {'type-light': this.state.type === 'light'}, | ||
| {'type-custom': !this.state.type} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. so 'custom' ends up being the same as not specifying a type, correct? To merge this, I'd like to see an example added to illustrate how to use it. |
||
| ) | ||
|
|
||
| let Wrapper = this.props.wrapper | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,8 @@ | ||
| @mixin type($background-color) { | ||
| background-color: $background-color; | ||
| border-radius: 3px; | ||
| font-size: 13px; | ||
| padding: 8px 21px; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see what you want to do - but adding them to something named 'background-color' seems misleading. Maybe we can define another mixing type, like base-sizing or something? |
||
| &.place-top { | ||
| &:after { | ||
| border-top-color: $background-color; | ||
|
|
@@ -55,12 +58,9 @@ | |
| } | ||
|
|
||
| .__react_component_tooltip { | ||
| border-radius: 3px; | ||
| display: inline-block; | ||
| font-size: 13px; | ||
| left: -999em; | ||
| opacity: 0; | ||
| padding: 8px 21px; | ||
| position: fixed; | ||
| pointer-events: none; | ||
| transition: opacity 0.3s ease-out; | ||
|
|
||