Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Custom Type for Unstyled Tooltip #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wylie wants to merge 3 commits into ReactTooltip:master from wylie:master
Closed

Custom Type for Unstyled Tooltip #293

wylie wants to merge 3 commits into ReactTooltip:master from wylie:master

Conversation

@wylie
Copy link

@wylie wylie commented Apr 26, 2017
edited
Loading

making a tooltip that has no presentation styles that need to be overridden with !important

  • moving some presentation styles so data-type="custom" can be used
  • adding custom to tooltipClass so we return no type-className class
  • updating the readme to reflect the newness

Wylie Fisher added 3 commits April 21, 2017 11:02
... than display. that way, by using the 'custom' data-type, one can start wioth a blank canvas
Copy link

danqing commented Jul 20, 2017

Would be great to see this merged!

Copy link
Collaborator

@aronhelser aronhelser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's been a while...
I like the idea, but we definitely need an example.

background-color: $background-color;
border-radius: 3px;
font-size: 13px;
padding: 8px 21px;
Copy link
Collaborator

@aronhelser aronhelser Apr 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you want to do - but adding them to something named 'background-color' seems misleading. Maybe we can define another mixing type, like base-sizing or something?

{'type-info': this.state.type === 'info'},
{'type-light': this.state.type === 'light'}
{'type-light': this.state.type === 'light'},
{'type-custom': !this.state.type}
Copy link
Collaborator

@aronhelser aronhelser Apr 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so 'custom' ends up being the same as not specifying a type, correct?

To merge this, I'd like to see an example added to illustrate how to use it.

thedaviddias reacted with thumbs up emoji
@wylie wylie closed this Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aronhelser aronhelser aronhelser requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /