-
Notifications
You must be signed in to change notification settings - Fork 289
Implement React components to reduce emitted MDX output from plugin #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sserrata
sserrata
added
enhancement
New feature or request
DO NOT MERGE
v4.0.0
v4.0.0
labels
Sep 28, 2024
|
Size Change: -310 kB (-13.63%) 👏 Total Size: 1.96 MB
i️ View Unchanged
|
Visit the preview URL for this PR (updated for commit ef8b1d9):
https://docusaurus-openapi-36b86--pr979-fgr4lcvg.web.app
(expires 2024年11月15日 15:14:40 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: bf293780ee827f578864d92193b8c2866acd459f
@sserrata
sserrata
force-pushed
the
params-details
branch
from
October 3, 2024 12:47
2974182 to
a387b7e
Compare
@sserrata
sserrata
changed the title
(削除) Add ParamsDetails component (削除ここまで)
(追記) Implement React components to reduce emitted MDX output from plugin (追記ここまで)
Oct 3, 2024
@sserrata
sserrata
force-pushed
the
params-details
branch
from
October 7, 2024 15:36
d4cf52f to
66e3ba9
Compare
Just went through a side-by-side comparison between existing demo build and this branch. So far, everything seems to align with some slight differences:
- Primitives are now rendered as a "tree"
SchemaItem - Now performing deep merge of resolved of allOf merge and existing schema minus the allOf (previously only shallow merge was performed)
@sserrata
sserrata
force-pushed
the
params-details
branch
from
October 7, 2024 21:08
0512243 to
bcac098
Compare
blindaa121
blindaa121
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far the changes look good on my end. Thanks for the huge refactor @sserrata! 🚀
@sserrata
sserrata
force-pushed
the
params-details
branch
from
October 8, 2024 16:26
0512243 to
bcac098
Compare
@sserrata
sserrata
force-pushed
the
params-details
branch
from
October 10, 2024 14:48
bcac098 to
3880c89
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
Massive refactor with goal of reducing overall MDX footprint for generated API docs. secondary goals are to improve maintainability, readability and reduce overall bundle size.
Preview: https://docusaurus-openapi-36b86--pr979-fgr4lcvg.web.app/