Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Fix] all of items in array for api response #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sserrata merged 1 commit into PaloAltoNetworks:main from ahelmy:fix-806
Oct 16, 2024

Conversation

@ahelmy
Copy link
Contributor

@ahelmy ahelmy commented Oct 14, 2024

Description

Fix allOf in the API response for objects.

Motivation and Context

Fixing #806

How Has This Been Tested?

  • Modified demo to local specs.
  • Tested and revert back to same demo specs.

Screenshots (if appropriate)

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

Copy link
Contributor Author

ahelmy commented Oct 14, 2024

@sserrata For your review please :)

Copy link
Member

Hi @ahelmy, thanks for the PR. In #979 I'm experimenting with a different library for resolving/merging allOf schemas. I'll make sure the scenario you addressed here is also covered.

ahelmy reacted with thumbs up emoji

Copy link

Visit the preview URL for this PR (updated for commit 6557a3d):

https://docusaurus-openapi-36b86--pr995-hlrmde1e.web.app

(expires 2024年11月15日 13:19:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bf293780ee827f578864d92193b8c2866acd459f

Copy link
Contributor Author

ahelmy commented Oct 16, 2024

thank you @sserrata 👍

@sserrata sserrata merged commit 3d1cc0d into PaloAltoNetworks:main Oct 16, 2024
13 checks passed
Copy link
Member

ahelmy reacted with hooray emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /