-
Couldn't load subscription status.
- Fork 275
Add target-ability to 'Next' button in select crypto scene #4256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+17
−17
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -202,19 +202,20 @@ const CreateWalletSelectCryptoComponent = (props: Props) => { | |
|
|
||
| const renderCreateWalletRow: ListRenderItem<WalletCreateItem> = useHandler(item => { | ||
| const { key, displayName, pluginId, tokenId } = item.item | ||
|
|
||
| const value = selectedItems[key] | ||
| const accessibilityHint = sprintf(lstrings.create_wallet_hint, displayName) | ||
| const accessibilityState = { checked: value, selected: value } | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is |
||
| const toggle = ( | ||
| <Switch | ||
| accessibilityState={accessibilityState} | ||
| accessibilityRole="switch" | ||
| accessibilityState={{ selected: selectedItems[key] }} | ||
| accessibilityHint={accessibilityHint} | ||
| ios_backgroundColor={theme.toggleButtonOff} | ||
| trackColor={{ | ||
| false: theme.toggleButtonOff, | ||
| true: theme.toggleButton | ||
| }} | ||
| value={selectedItems[key]} | ||
| value={value} | ||
| onValueChange={() => handleCreateWalletToggle(key)} | ||
| /> | ||
| ) | ||
|
|
@@ -223,6 +224,7 @@ const CreateWalletSelectCryptoComponent = (props: Props) => { | |
| <CreateWalletSelectCryptoRow | ||
| pluginId={pluginId} | ||
| tokenId={tokenId} | ||
| key={displayName} | ||
| walletName={displayName} | ||
| onPress={() => handleCreateWalletToggle(key)} | ||
| rightSide={toggle} | ||
|
|
@@ -235,12 +237,10 @@ const CreateWalletSelectCryptoComponent = (props: Props) => { | |
| const renderNextButton = React.useMemo( | ||
| () => ( | ||
| <Fade noFadeIn={defaultSelection.length > 0} visible={numSelected > 0} duration={300}> | ||
| <View style={styles.bottomButton}> | ||
| <MainButton label={lstrings.string_next_capitalized} type="primary" marginRem={[0, -0.5]} onPress={handleNext} alignSelf="center" /> | ||
| </View> | ||
| <MainButton label={lstrings.string_next_capitalized} type="primary" marginRem={[0, -0.5]} onPress={handleNext} alignSelf="center" /> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This appears to be a non-functional cleanup. If that's the case it should be in a separate commit at the beginning |
||
| </Fade> | ||
| ), | ||
| [defaultSelection, handleNext, numSelected, styles.bottomButton] | ||
| [defaultSelection, handleNext, numSelected] | ||
| ) | ||
|
|
||
| return ( | ||
|
|
@@ -273,18 +273,18 @@ const CreateWalletSelectCryptoComponent = (props: Props) => { | |
| keyExtractor={keyExtractor} | ||
| renderItem={renderCreateWalletRow} | ||
| /> | ||
| {renderNextButton} | ||
| <View style={styles.bottomArea}>{renderNextButton}</View> | ||
| </View> | ||
| )} | ||
| </SceneWrapper> | ||
| ) | ||
| } | ||
|
|
||
| const getStyles = cacheStyles((theme: Theme) => ({ | ||
| bottomButton: { | ||
| alignSelf: 'center', | ||
| bottom: theme.rem(1), | ||
| position: 'absolute' | ||
| bottomArea: { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. were these changes tested with the keyboard visible? |
||
| flex: 1, | ||
| justifyContent: 'flex-end', | ||
| paddingBottom: theme.rem(1) | ||
| }, | ||
| content: { | ||
| flex: 1 | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.