Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add target-ability to 'Next' button in select crypto scene #4256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itay747 wants to merge 2 commits into develop
base: develop
Choose a base branch
Loading
from itay/maestro/create-crypto-next

Conversation

@itay747
Copy link
Contributor

@itay747 itay747 commented Jun 9, 2023 •
edited
Loading

CHANGELOG

none

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

image

@itay747 itay747 requested a review from peachbits June 9, 2023 13:38

constvalue=selectedItems[key]
const accessibilityHint = sprintf(lstrings.create_wallet_hint, displayName)
const accessibilityState = { checked: value, selected: value }
Copy link
Contributor

@peachbits peachbits Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is selected still necessary here?

<View style={styles.bottomButton}>
<MainButton label={lstrings.string_next_capitalized} type="primary" marginRem={[0, -0.5]} onPress={handleNext} alignSelf="center" />
</View>
<MainButton label={lstrings.string_next_capitalized} type="primary" marginRem={[0, -0.5]} onPress={handleNext} alignSelf="center" />
Copy link
Contributor

@peachbits peachbits Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be a non-functional cleanup. If that's the case it should be in a separate commit at the beginning

alignSelf: 'center',
bottom: theme.rem(1),
position: 'absolute'
bottomArea: {
Copy link
Contributor

@peachbits peachbits Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were these changes tested with the keyboard visible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peachbits peachbits peachbits requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /