-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Additional unit tests for AdvancedCollectionView #4347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
XAML-Knight
wants to merge
4
commits into
CommunityToolkit:main
from
XAML-Knight:dev/AdvancedCollection_OutOfRange
Open
Additional unit tests for AdvancedCollectionView #4347
XAML-Knight
wants to merge
4
commits into
CommunityToolkit:main
from
XAML-Knight:dev/AdvancedCollection_OutOfRange
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@XAML-Knight
XAML-Knight
requested review from
Sergio0694,
azchohfi,
michael-hawker and
shweaver-MSFT
October 27, 2021 17:47
ghost
commented
Oct 27, 2021
Thanks XAML-Knight for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌
Pending the successful approval of related PR #4349 and merge in with main, this PR is to then later be rebased on top of those changes.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes none, but attempts to address #4339
PR Type
Adding additional unit tests for AdvancedCollectionView
What is the current behavior?
What is the new behavior?
More unit tests for AdvancedCollectionView, to help provide coverage for an issue that was found in a drag and drop scenario (#4339).
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
See #4339 for more info; to emulate drag and drop, the
Yearproperty is modified after removing it from the first ACV, and before adding ("dropping") to the second ACV