-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix view bad insert index #4524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix issue #4465
ghost
commented
Mar 26, 2022
Thanks texaclou for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌
@ghost
ghost
added
the
bug 🐛
An unexpected issue that highlights incorrect behavior
label
Mar 26, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4465
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
When ACV (AdvancedCollectionView) use a filter
When ACV don't use SortDescription
When a new item is inserted at the end of the source
Then new item is inserted in view before the last item.
What is the new behavior?
Now the new item is inserted in view after the last item, at the end.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information