Called function not returning a value in python

Ok, you've got a few different issues at play here.

1. You don't return anything from function fgp: the return; at the end of fgp returns None, which in Python, indicates the absence of a value. Don't want that! Instead, use: return fgp.
2. You're not calling fgp in fgpoutput - you're simply printing the function itself. Instead, you want to call the function like this: fgp(x, y), which now returns the calculated value.
3. They way you construct output isn't quite right. In Python, there's a string method for formatting strings to include numbers: str.format(). Check out the documentation on it here.

So, altogether we get:

def fgp(x, y):
 fgp = (x/y)*100
 return fgp
def fgpoutput():
 x = int(input("How many shots made?"));
 y = int(input("How many shots attempted?")); 
 output = "This player is shooting {} %".format(fgp(x, y))
 print(output)
fgpoutput()

Overall though, you're definitely on the right track. Good luck!

output = "This player is shooting",fgp,"%" is printing the "fgp" function itself, not what it is calculating. What you are probably looking for is:

def fgp(x, y):
 return (x / y) * 100

That will return the value you want to calculate. Then you can call it in your output:

def fgpoutput():
 x = int(input("How many shots made?"))
 y = int(input("How many shots attempted?"))
 result = fgp(x, y)
 output = "This player is shooting {} %".format(result)
 print(output)

Also, you don't need the semicolons at the end of the lines in Python.

A function is, as everything else in Python, an object. When printing fgp, you are printing a reference to the executable function object.

But, differing to Matlab, to return from a function in Python, you actually have to return the value:

def fgp(x, y):
 return (x/y) * 100

If you want to call fgp, you'll have to execute it:

output = "This player is shooting", fgp(x, y), "%"

There appear to be a few problems

First the function -

def fgp(x, y):
 fgp = (x/y) * 100
 return;

In the function above you are using 'fgp' again inside the function 'fgp'. That per se is not a problem (the function fgp is a global while the fgp inside function fgp is local), but it's extremely unreadable and confusing. You should use something like 'f' if you have to.

Second -

(x/y) * 100

This function will almost always return 0 (if both x and y are integers and in your case they are and x < y). That line should look something like

(x * 100.0) / y # force the numerator to a float

So your fgp becomes

def fgp(x,y):
 assert y is not 0
 return (x * 100.0/y) 

Let it raise an AssertionError if y happens to be zero. This shoud be it

• python