phpwiki-talk Mailing List for PhpWiki

Hello Reini,
I fixed a problem in CreateTocPlugin. When displaying an old
revision of the page, the TOC was always taken from the
latest revision.
What is still incorrect in that when you preview the
modifications and have added, removed or otherwise changed
the headers, the TOC is calculated from the latest saved
revision.
This confuses our users.
Can you please help me to fix this? I have no idea.
Best regards,
Marc-Etienne
-- 
Marc-Etienne Vargenau
Alcatel-Lucent France, Route de Villejust, 91620 NOZAY, FRANCE
+33 (0)1 30 77 28 33, Mar...@al...

>
> I think using "name" should work in all cases, except in very
> old browsers (NS4). It works in IE6.
Oops...
I meant 'using "id" should work in all cases'...
Sorry about it.
Marc-Etienne
-- 
Marc-Etienne Vargenau
Alcatel-Lucent France, Route de Villejust, 91620 NOZAY, FRANCE
+33 (0)1 30 77 28 33, Mar...@al...

Le 21/09/2010 16:18, Reini Urban a écrit :
> 2010年9月21日 Marc-Etienne Vargenau<Mar...@al...>:
>> Le 21/09/2010 09:08, ru...@us... a écrit :
>>> Revision: 7704
>>> http://phpwiki.svn.sourceforge.net/phpwiki/?rev=7704&view=rev
>>> Author: rurban
>>> Date: 2010年09月21日 07:08:56 +0000 (2010年9月21日)
>>>
>>> Log Message:
>>> -----------
>>> revert 7551-7553. we use named anchors to jump to, not internal ids
>>>
>>> Modified Paths:
>>> --------------
>>> trunk/lib/plugin/CreateToc.php
>>>
>>> Modified: trunk/lib/plugin/CreateToc.php
>>
>> Hello Reini,
>>
>> I do not really agree with this one.
>> Both ids and names can be used for anchors, and name is
>> deprecated for<a>. It no longer exists in XHTML 1.1 and HTML 5.
>
> hmm, so if we are in quirks mode we should use name to be able to jump
> to #anchor,
> and if strict xhtml (ENABLE_XHTML_XML) we should use id, right?
I think using "name" should work in all cases, except in very
old browsers (NS4). It works in IE6.
Regards,
Marc-Etienne
-- 
Marc-Etienne Vargenau
Alcatel-Lucent France, Route de Villejust, 91620 NOZAY, FRANCE
+33 (0)1 30 77 28 33, Mar...@al...

2010年9月21日 Marc-Etienne Vargenau <Mar...@al...>:
> Le 21/09/2010 09:08, ru...@us... a écrit :
>> Revision: 7704
>>      http://phpwiki.svn.sourceforge.net/phpwiki/?rev=7704&view=rev
>> Author:  rurban
>> Date:   2010年09月21日 07:08:56 +0000 (2010年9月21日)
>>
>> Log Message:
>> -----------
>> revert 7551-7553. we use named anchors to jump to, not internal ids
>>
>> Modified Paths:
>> --------------
>>   trunk/lib/plugin/CreateToc.php
>>
>> Modified: trunk/lib/plugin/CreateToc.php
>
> Hello Reini,
>
> I do not really agree with this one.
> Both ids and names can be used for anchors, and name is
> deprecated for <a>. It no longer exists in XHTML 1.1 and HTML 5.
hmm, so if we are in quirks mode we should use name to be able to jump
to #anchor,
and if strict xhtml (ENABLE_XHTML_XML) we should use id, right?
-- 
Reini Urban

Le 21/09/2010 09:08, ru...@us... a écrit :
> Revision: 7704
> http://phpwiki.svn.sourceforge.net/phpwiki/?rev=7704&view=rev
> Author: rurban
> Date: 2010年09月21日 07:08:56 +0000 (2010年9月21日)
>
> Log Message:
> -----------
> revert 7551-7553. we use named anchors to jump to, not internal ids
>
> Modified Paths:
> --------------
> trunk/lib/plugin/CreateToc.php
>
> Modified: trunk/lib/plugin/CreateToc.php
Hello Reini,
I do not really agree with this one.
Both ids and names can be used for anchors, and name is
deprecated for <a>. It no longer exists in XHTML 1.1 and HTML 5.
Best regards,
Marc-Etienne
-- 
Marc-Etienne Vargenau
Alcatel-Lucent France, Route de Villejust, 91620 NOZAY, FRANCE
+33 (0)1 30 77 28 33, Mar...@al...

Le 21/09/2010 08:08, ru...@us... a écrit :
> Revision: 7702
> http://phpwiki.svn.sourceforge.net/phpwiki/?rev=7702&view=rev
> Author: rurban
> Date: 2010年09月21日 06:08:32 +0000 (2010年9月21日)
>
> Log Message:
> -----------
> new may return an empty object. we must check for _userid to avoid recursion cycles
>
> Modified Paths:
> --------------
> trunk/lib/WikiUserNew.php
Hello Reini,
Can you please carefully check file WikiUserNew.php?
I reverted some of the changes because I could no longer
save user preferences.
I might have reverted too many things.
Best regards,
Marc-Etienne
-- 
Marc-Etienne Vargenau
Alcatel-Lucent France, Route de Villejust, 91620 NOZAY, FRANCE
+33 (0)1 30 77 28 33, Mar...@al...

2010年9月17日 Marc-Etienne Vargenau <Mar...@al...>:
> Le 17/09/2010 13:49, Reini Urban a écrit :
>> Marc-Etienne,
>> Do you want to formally announce the rc1 release?
>> You did most of the work.
>>
>> As you see I found some minor bugs when installing completely from
>> scratch on windows.
>
> Hello Reini,
>
> Great news.
> It certainly needs some more testing, we will make a
> formal announce for 1.4.0 final.
Sure.
> I do not test on Windows, only Linux and Mac OS X.
I only did some minor testing on Windows yet.
> You did not create a tag and a branch, do we need to do it?
branch not.
tag probably not, only real releases.
> What procedure do you use to create the ZIP file?
on windows after removing config/config.ini:
 zip -r <reldir>.zip <reldir>
> I would like to create an RPM file for Linux, is there a spec
> for that somewhere?
Not that I know of.
But there's a debian deb with a different layout. ini in etc, ...)
admin should be in /usr/lib/phpwiki/admin probably, ...
-- 
Reini Urban
http://phpwiki.org/      http://murbreak.at/

Hi,
Excellent, that’s brilliant news!
Thanks a mil,
Sébastien.
On 17/09/2010 13:51, Marc-Etienne Vargenau wrote:
> Le 17/09/2010 13:49, Reini Urban a écrit :
>> Marc-Etienne,
>> Do you want to formally announce the rc1 release?
>> You did most of the work.
>>
>> As you see I found some minor bugs when installing completely from
>> scratch on windows.
>
> Hello Reini,
>
> Great news.
> It certainly needs some more testing, we will make a
> formal announce for 1.4.0 final.
>
> I do not test on Windows, only Linux and Mac OS X.
>
> You did not create a tag and a branch, do we need to do it?
>
> What procedure do you use to create the ZIP file?
> I would like to create an RPM file for Linux, is there a spec
> for that somewhere?
>
> Best regards,
>
> Marc-Etienne
>

Le 17/09/2010 13:49, Reini Urban a écrit :
> Marc-Etienne,
> Do you want to formally announce the rc1 release?
> You did most of the work.
>
> As you see I found some minor bugs when installing completely from
> scratch on windows.
Hello Reini,
Great news.
It certainly needs some more testing, we will make a
formal announce for 1.4.0 final.
I do not test on Windows, only Linux and Mac OS X.
You did not create a tag and a branch, do we need to do it?
What procedure do you use to create the ZIP file?
I would like to create an RPM file for Linux, is there a spec
for that somewhere?
Best regards,
Marc-Etienne
-- 
Marc-Etienne Vargenau
Alcatel-Lucent France, Route de Villejust, 91620 NOZAY, FRANCE
+33 (0)1 30 77 28 33, Mar...@al...

Marc-Etienne,
Do you want to formally announce the rc1 release?
You did most of the work.
As you see I found some minor bugs when installing completely from
scratch on windows.
-- 
Reini Urban
http://phpwiki.org/      http://murbreak.at/

Le 13/09/2010 17:44, Sébastien Le Callonnec a écrit :
> Hi Marc-Étienne,
>
> Ok, thanks, I’ll have a look! Is that happening in specific conditions?
Hello Sébastien,
As indicated in the error message, I am using Pear to
access the database and My SQL.
PHP 5.2.6 under Linux.
Best regards,
Marc-Etienne
-- 
Marc-Etienne Vargenau
Alcatel-Lucent France, Route de Villejust, 91620 NOZAY, FRANCE
+33 (0)1 30 77 28 33, Mar...@al...

Hi Marc-Étienne,
Ok, thanks, I’ll have a look! Is that happening in specific conditions?
Regards,
Sébastien.
On 13/09/2010 16:21, Marc-Etienne Vargenau wrote:
> Le 11/09/2010 00:02, Sébastien Le Callonnec a écrit :
>> Hi Marc-Étienne,
>>
>>
>> I’m curious as to what error this patch caused so that I can have a
>> look, rather than blindly reverting it -- the "AllPages" plugin is now
>> again broken in my environments, which doesn’t seem to me like a
>> convergent approach.
>
> Hello Sébastien,
>
> First let me say that you are very welcome to contribute to Phpwiki.
>
> For me, your patch produces the following error, that is why I reverted.
>
> Fatal Error:
>
> lib/WikiDB/backend/PearDB.php (In template 'body' < 'html'):1061 Error:
> WikiDB_backend_PearDB_mysql: fatal database error
>
> * DB Error: syntax error
> * (SELECT page.id AS id, page.pagename AS pagename, page.hits AS hits
> FROM page WHERE AND page.pagename NOT IN ('') ORDER BY pagename ASC
> LIMIT 0, 1000 [nativecode=1064 ** You have an error in your SQL syntax;
> check the manual that corresponds to your MySQL server version for the
> right syntax to use near 'AND page.pagename NOT IN ('') ORDER BY
> pagename ASC LIMIT 0, 1000' at line 1])
>
> Reini, can you please check what is going on?
>
> Best regards,
>
> Marc-Etienne
>

Le 11/09/2010 00:02, Sébastien Le Callonnec a écrit :
> Hi Marc-Étienne,
>
>
> I’m curious as to what error this patch caused so that I can have a
> look, rather than blindly reverting it -- the "AllPages" plugin is now
> again broken in my environments, which doesn’t seem to me like a
> convergent approach.
Hello Sébastien,
First let me say that you are very welcome to contribute to Phpwiki.
For me, your patch produces the following error, that is why I reverted.
Fatal Error:
lib/WikiDB/backend/PearDB.php (In template 'body' < 'html'):1061 Error: 
WikiDB_backend_PearDB_mysql: fatal database error
 * DB Error: syntax error
 * (SELECT page.id AS id, page.pagename AS pagename, page.hits AS 
hits FROM page WHERE AND page.pagename NOT IN ('') ORDER BY pagename ASC 
LIMIT 0, 1000 [nativecode=1064 ** You have an error in your SQL syntax; 
check the manual that corresponds to your MySQL server version for the 
right syntax to use near 'AND page.pagename NOT IN ('') ORDER BY 
pagename ASC LIMIT 0, 1000' at line 1])
Reini, can you please check what is going on?
Best regards,
Marc-Etienne
-- 
Marc-Etienne Vargenau
Alcatel-Lucent France, Route de Villejust, 91620 NOZAY, FRANCE
+33 (0)1 30 77 28 33, Mar...@al...

Hi Marc-Étienne,
I’m curious as to what error this patch caused so that I can have a 
look, rather than blindly reverting it -- the "AllPages" plugin is now 
again broken in my environments, which doesn’t seem to me like a 
convergent approach.
Thanks,
Sébastien.
On 10/09/2010 12:31, var...@us... wrote:
> Revision: 7681
> http://phpwiki.svn.sourceforge.net/phpwiki/?rev=7681&view=rev
> Author: vargenau
> Date: 2010年09月10日 11:31:37 +0000 (2010年9月10日)
>
> Log Message:
> -----------
> revert of Patch 3024787 by S?195円?169円bastien Le Callonnec (caused an SQL syntax error)
>
> Modified Paths:
> --------------
> trunk/TODO
> trunk/lib/plugin/AllPages.php
>
> Modified: trunk/TODO
> ===================================================================
> --- trunk/TODO	2010年09月10日 11:27:57 UTC (rev 7680)
> +++ trunk/TODO	2010年09月10日 11:31:37 UTC (rev 7681)
> @@ -4,6 +4,7 @@
> * AllPages give too many pages
> * WantedPages give too many pages (from interwiki map)
> (to be tested in both Pear and ADODB)
> +* revert of Patch 3024787 by Sébastien Le Callonnec (caused an SQL syntax error)
>
> == Others==
> * Minimizer for JS/CSS
>
> Modified: trunk/lib/plugin/AllPages.php
> ===================================================================
> --- trunk/lib/plugin/AllPages.php	2010年09月10日 11:27:57 UTC (rev 7680)
> +++ trunk/lib/plugin/AllPages.php	2010年09月10日 11:31:37 UTC (rev 7681)
> @@ -67,18 +67,17 @@
> $timer = new DebugTimer;
> }
> $caption = _("All pages in this wiki (%d total):");
> - $exclude_empty_pagename = array('');
>
> if ( !empty($args['userpages']) ) {
> $pages = PageList::allUserPages($args['include_empty'],
> - $args['sortby'], '',
> - $exclude_empty_pagename);
> + $args['sortby'], ''
> + );
> $caption = _("List of user-created pages (%d total):");
> $args['count'] = $request->getArg('count');
> } elseif ( !empty($args['owner']) ) {
> $pages = PageList::allPagesByOwner($args['owner'], $args['include_empty'],
> - $args['sortby'], '',
> - $exclude_empty_pagename);
> + $args['sortby'], ''
> + );
> $args['count'] = $request->getArg('count');
> if (!$args['count'])
> $args['count'] = $dbi->numPages($args['include_empty'], $args['exclude']);
> @@ -90,8 +89,8 @@
> $pages->_options['count'] = $args['count'];
> } elseif ( !empty($args['author']) ) {
> $pages = PageList::allPagesByAuthor($args['author'], $args['include_empty'],
> - $args['sortby'], '',
> - $exclude_empty_pagename);
> + $args['sortby'], ''
> + );
> $args['count'] = $request->getArg('count');
> if (!$args['count'])
> $args['count'] = $dbi->numPages($args['include_empty'], $args['exclude']);
> @@ -103,8 +102,7 @@
> $pages->_options['count'] = $args['count'];
> } elseif ( !empty($args['creator']) ) {
> $pages = PageList::allPagesByCreator($args['creator'], $args['include_empty'],
> - $args['sortby'], '',
> - $exclude_empty_pagename
> + $args['sortby'], ''
> );
> $args['count'] = $request->getArg('count');
> if (!$args['count'])
> @@ -115,6 +113,8 @@
> : $args['creator'],
> 'if_known'), $args['count']);
> $pages->_options['count'] = $args['count'];
> + //} elseif ($pages) {
> + // $args['count'] = count($pages);
> } else {
> if (! $request->getArg('count'))
> $args['count'] = $dbi->numPages($args['include_empty'], $args['exclude']);
> @@ -126,17 +126,15 @@
> $pagelist = new PageList($args['info'], $args['exclude'], $args);
> if (!$args['noheader']) $pagelist->setCaption($caption);
>
> - if ($pages !== false) {
> + // deleted pages show up as version 0.
> + //if ($args['include_empty'])
> + // $pagelist->_addColumn('version');
> +
> + if ($pages !== false)
> $pagelist->addPageList($pages);
> - }
> - else {
> - // Clear count as previous value was for non-empty pages.
> - $pagelist->clearArg('count');
> - $pagelist->addPages($dbi->getAllPages($args['include_empty'],
> - $args['sortby'],
> - $args['limit'],
> - $exclude_empty_pagename));
> - }
> + else
> + $pagelist->addPages( $dbi->getAllPages($args['include_empty'], $args['sortby'],
> + $args['limit']) );
> if (DEBUG&& $args['debug']) {
> return HTML($pagelist,
> HTML::p(fmt("Elapsed time: %s s", $timer->getStats())));
>
>
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
>
> ------------------------------------------------------------------------------
> Automate Storage Tiering Simply
> Optimize IT performance and efficiency through flexible, powerful,
> automated storage tiering capabilities. View this brief to learn how
> you can reduce costs and improve performance.
> http://p.sf.net/sfu/dell-sfdev2dev
> _______________________________________________
> phpwiki-checkins mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpwiki-checkins