phpwiki-talk Mailing List for PhpWiki

Hi Christof,
Thank you for your patches.
I have published them in Subversion.
Best regards,
Marc-Etienne
--
Marc-Etienne Vargenau mar...@no...<mailto:mar...@no...>
Nokia, 12, rue Jean-Bart, 91300 Massy, FRANCE
Mobile: +33 6 24 49 78 68<tel:+33624497868>
Senior Specialist Open Source
Planned absence: 4-22 August
De : Christof Meerwald via Phpwiki-talk <php...@li...>
Date : mardi, 29 juillet 2025 à 23:24
À : Phpwiki-talk <php...@li...>
Cc : Christof Meerwald <cm...@cm...>
Objet : Re: [Phpwiki-talk] Missing access checks in CreatePage and AppendText plugins
CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
On Tue, Jul 29, 2025 at 11:04:24PM +0200, Christof Meerwald wrote:
> Noticed that the CreatePage and AppendText plugins let unauthenticated
> users create pages or let them append text to pages, e.g.
Actually, WikiAdminDeleteAcl is also missing an access check, patch
attached.
Christof
--
https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcmeerw.org%2F&data=05%7C02%7Cmarc-etienne.vargenau%40nokia.com%7C4e796218c09f47fe61f408ddcee6362f%7C5d4717519675428d917b70f44f9630b0%7C0%7C0%7C638894210508983458%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=w%2B9pGigz7tN%2BhTJYA2nrg%2FgQ34nH6B59h0smjnzcheg%3D&reserved=0<https://cmeerw.org/> sip:cmeerw at cmeerw.org
mailto:cmeerw at cmeerw.org xmpp:cmeerw at cmeerw.org

On Tue, Jul 29, 2025 at 11:04:24PM +0200, Christof Meerwald wrote:
> Noticed that the CreatePage and AppendText plugins let unauthenticated
> users create pages or let them append text to pages, e.g.
Actually, WikiAdminDeleteAcl is also missing an access check, patch
attached.
Christof
-- 
https://cmeerw.org sip:cmeerw at cmeerw.org
mailto:cmeerw at cmeerw.org xmpp:cmeerw at cmeerw.org

Noticed that the CreatePage and AppendText plugins let unauthenticated
users create pages or let them append text to pages, e.g.
https://wikiurl.example.com/CreatePage?s=Test&template=Template/Example&initial_content=Hello
or
https://wikiurl.example.com/AppendText?page=HomePage&s=Test
Patch attached.
Christof
-- 
https://cmeerw.org sip:cmeerw at cmeerw.org
mailto:cmeerw at cmeerw.org xmpp:cmeerw at cmeerw.org

Hi Christof,
Thank you for the report.
I have created a new release of PhpWiki
https://sourceforge.net/p/phpwiki/news/2025/05/-phpwiki-166-released-/
Best regards,
Marc-Etienne
--
Marc-Etienne Vargenau mar...@no...<mailto:mar...@no...>
Nokia, 12, rue Jean-Bart, 91300 Massy, FRANCE
Mobile: +33 6 24 49 78 68<tel:+33624497868>
Senior Specialist Open Source
Planned absence: 8 May
De : Christof Meerwald via Phpwiki-talk <php...@li...>
Date : dimanche, 20 avril 2025 à 16:15
À : php...@li... <php...@li...>
Cc : Christof Meerwald <cm...@cm...>
Objet : [Phpwiki-talk] Missing space for 'ORDER BY' in PDO.php
CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
ORDER BY clause needs a space to get valid SQL, patch attached.
Christof
--

ORDER BY clause needs a space to get valid SQL, patch attached.
Christof
-- 
https://cmeerw.org sip:cmeerw at cmeerw.org
mailto:cmeerw at cmeerw.org xmpp:cmeerw at cmeerw.org

Hello,
PhpWiki 1.6.4 has been published.
You can download it at: https://sourceforge.net/projects/phpwiki/
 * Upgrade PEAR to release 1.10.14, PEAR DB to release 1.12.1
 * Check for "shell_exec" before using it (Christof Meerwald)
 * Improve RSS (Christof Meerwald)
 * Add support for SQLite in PDO, add support for SQLite3 in PEAR (Christof Meerwald)
Big thanks to Christof Meerwald for the patches he provided.
Best regards,
Marc-Etienne
--
Marc-Etienne Vargenau mar...@no...<mailto:mar...@no...>
Nokia, 12, rue Jean-Bart, 91300 Massy, FRANCE
Mobile: +33 6 24 49 78 68
Senior Specialist Open Source
Planned absence: none

Thank you Christof.
I have implemented your patch in Subversion.
Best regards,
Marc-Etienne
--
Marc-Etienne Vargenau mar...@no...<mailto:mar...@no...>
Nokia, 12, rue Jean-Bart, 91300 Massy, FRANCE
Mobile: +33 6 24 49 78 68<tel:+33624497868>
Senior Specialist Open Source
Planned absence: none
De : Christof Meerwald via Phpwiki-talk <php...@li...>
Date : samedi, 17 février 2024 à 17:47
À : php...@li... <php...@li...>
Cc : Christof Meerwald <cm...@cm...>
Objet : [Phpwiki-talk] Uncaught TypeError: Cannot access offset of type string on string in phpwiki/lib/stdlib.php:172
CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
This one can be triggered by going to PageHistory and then clicking on
"RSS" (note that "RSS2" or "Atom" don't generate a page-specific
history there, but that's another issue). The second argument to
WikiURL should definitely be an array and not a string, patch attached.
Christof
--
https://cmeerw.org sip:cmeerw at cmeerw.org
mailto:cmeerw at cmeerw.org xmpp:cmeerw at cmeerw.org

This one can be triggered by going to PageHistory and then clicking on
"RSS" (note that "RSS2" or "Atom" don't generate a page-specific
history there, but that's another issue). The second argument to
WikiURL should definitely be an array and not a string, patch attached.
Christof
-- 
https://cmeerw.org sip:cmeerw at cmeerw.org
mailto:cmeerw at cmeerw.org xmpp:cmeerw at cmeerw.org

Hi Christof,
Thank you for the report.
I have fixed the test, now testing against "array()" instead of "false".
Best regards,
Marc-Etienne
--
Marc-Etienne Vargenau mar...@no...<mailto:mar...@no...>
Nokia, 12, rue Jean-Bart, 91300 Massy, FRANCE
Mobile: +33 6 24 49 78 68<tel:+33624497868>
Senior Specialist Open Source
Planned absence: none
De : Christof Meerwald via Phpwiki-talk <php...@li...>
Date : dimanche, 21 janvier 2024 à 19:57
À : php...@li... <php...@li...>
Cc : Christof Meerwald <cm...@cm...>
Objet : [Phpwiki-talk] FileFinder.php default path logic
CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
I don't think it makes sense to check if the member has already been
set in the constructor. And having the default argument "array()", but
then comparing against "false" means we never get into the then
branch. Patch is attached (so we only use the _get_include_path if
FileFinder has been called with no argument specified, which I think
is the intention here).
Christof
--
https://cmeerw.org sip:cmeerw at cmeerw.org
mailto:cmeerw at cmeerw.org xmpp:cmeerw at cmeerw.org

"shell_exec" might have been disabled in the PHP configuration, this
will result in a hard error when trying to use ` (shell_exec), so
check for it.
(btw, there is another use in Units.php, but that can be disabled with
DISABLE_UNITS=1, so didn't bother to patch that one)
Christof
-- 
https://cmeerw.org sip:cmeerw at cmeerw.org
mailto:cmeerw at cmeerw.org xmpp:cmeerw at cmeerw.org

There is a _HttpAuthPassUser::_fake_auth in WikiUser.php, so those
methods should probably be static, patch attached.
Christof
-- 
https://cmeerw.org sip:cmeerw at cmeerw.org
mailto:cmeerw at cmeerw.org xmpp:cmeerw at cmeerw.org

I don't think it makes sense to check if the member has already been
set in the constructor. And having the default argument "array()", but
then comparing against "false" means we never get into the then
branch. Patch is attached (so we only use the _get_include_path if
FileFinder has been called with no argument specified, which I think
is the intention here).
Christof
-- 
https://cmeerw.org sip:cmeerw at cmeerw.org
mailto:cmeerw at cmeerw.org xmpp:cmeerw at cmeerw.org

Another patch to fix atom feeds:
PHP Fatal error: Uncaught TypeError: Illegal offset type in isset or empty in phpwiki/lib/RssWriter.php:191
Stack trace:
#0 phpwiki/lib/RssWriter.php(175): RssWriter->__uniquify_uri(Array)
#1 phpwiki/lib/RssWriter.php(269): RssWriter->__node('feed', Array, Array)
#2 phpwiki/lib/plugin/RecentChanges.php(1147): AtomFeed->feed(Array)
Christof
-- 
https://cmeerw.org sip:cmeerw at cmeerw.org
mailto:cmeerw at cmeerw.org xmpp:cmeerw at cmeerw.org

attached a patch to make defaultPerms and accessTypes static so they
can be called from (static) dotPerms.
Can be triggered by opening a page whose name starts with a "."
Christof
-- 
https://cmeerw.org sip:cmeerw at cmeerw.org
mailto:cmeerw at cmeerw.org xmpp:cmeerw at cmeerw.org

Hi Christof,
Thank you for your report and patches.
I will test them and integrate them.
I must say that there are some issues with PDO. "DATABASE_TYPE = SQL" (PEAR DB) has been more tested than PDO, and it is what I use.
Best wishes for the new year 2024.
Marc-Etienne
--
Marc-Etienne Vargenau mar...@no...<mailto:mar...@no...>
Nokia, 12, rue Jean-Bart, 91300 Massy, FRANCE
Mobile: +33 6 24 49 78 68<tel:+33624497868>
Senior Specialist Open Source
Planned absence: 1-7 January
De : Christof Meerwald via Phpwiki-talk <php...@li...>
Date : samedi, 30 décembre 2023 à 20:15
À : php...@li... <php...@li...>
Cc : Christof Meerwald <cm...@cm...>
Objet : [Phpwiki-talk] PDO sqlite backend
CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
So far I have been using phpwiki with the dba backend, but web hosters
don't always make dba available, so been investigating using SQLite as
the backend. Anyway, tried to use PDO, but ran into a few issues - I
have attached a patch that makes it work (at least for me).
BTW, not really sure what that "$date > 1588437560" check was all
about (1588437560 corresponds to "Sat May 2 18:39:20 2020").
Also not entirely sure what that "else" branch in PDO.php was trying
to do with the database dsn - I am just passing the DATABASE_DSN to
PDO there now (e.g. DATABASE_DSN = "sqlite:/path/to/file.db")
Christof
--
https://cmeerw.org sip:cmeerw at cmeerw.org
mailto:cmeerw at cmeerw.org xmpp:cmeerw at cmeerw.org

So far I have been using phpwiki with the dba backend, but web hosters
don't always make dba available, so been investigating using SQLite as
the backend. Anyway, tried to use PDO, but ran into a few issues - I
have attached a patch that makes it work (at least for me).
BTW, not really sure what that "$date > 1588437560" check was all 
about (1588437560 corresponds to "Sat May 2 18:39:20 2020").
Also not entirely sure what that "else" branch in PDO.php was trying 
to do with the database dsn - I am just passing the DATABASE_DSN to
PDO there now (e.g. DATABASE_DSN = "sqlite:/path/to/file.db")
Christof
-- 
https://cmeerw.org sip:cmeerw at cmeerw.org
mailto:cmeerw at cmeerw.org xmpp:cmeerw at cmeerw.org

Hello Harold,
>From the wiki itself, you can check the SystemInfo page.
For example: http://phpwiki.demo.free.fr/index.php/SystemInfo
In the source code, you have it in file ./lib/prepend.php:define('PHPWIKI_VERSION', '1.6.3');
Best regards,
Marc-Etienne
--
Marc-Etienne Vargenau mar...@no...<mailto:mar...@no...>
Nokia, 12, rue Jean-Bart, 91300 Massy, FRANCE
Mobile: +33 6 24 49 78 68<tel:+33624497868>
Senior Specialist Open Source
Planned absence: none
De : Harold Hallikainen <ha...@ha...>
Date : dimanche, 24 décembre 2023 à 19:46
À : php...@li... <php...@li...>
Objet : [Phpwiki-talk] How to determine installed PhpWiki version?
CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
Is there an easy way to determine what version I have installed?
Thanks!
Harold
_______________________________________________
Phpwiki-talk mailing list
Php...@li...
https://lists.sourceforge.net/lists/listinfo/phpwiki-talk

Is there an easy way to determine what version I have installed?
Thanks!
Harold

Hi Marc-Etienne - I've installed 1.6.3 and confirm it's working.
Thanks a lot,
Thom.
On Thursday, 16 November 2023 at 15:57, Marc-Etienne Vargenau (Nokia) <mar...@no...> wrote:
> Hi Thom,
>
> I have just published PhpWiki 1.6.3 with a fix for your issue.
>
> You can download it at: https://sourceforge.net/projects/phpwiki/
>
> Thank you again for your bug report.
>
> Best regards,
>
> Marc-Etienne
>
> --
> Marc-Etienne Vargenau mar...@no...
> Nokia, 12, rue Jean-Bart, 91300 Massy, FRANCE
> Mobile: [+33 6 24 49 78 68](tel:+33624497868)
>
> Senior Specialist Open Source
> Planned absence: none
>
> De : Marc-Etienne Vargenau (Nokia) <mar...@no...>
> Date : mercredi, 8 novembre 2023 à 19:55
> À : Discussion on PhpWiki features, bugs, development. <php...@li...>
> Cc : Thom Jeera <tho...@pr...>
> Objet : Re: [Phpwiki-talk] TypeError in ExternalReferrer under php8
>
> Hi Thom,
>
> Thank you for the report.
>
> I will test and provide a fix.
>
> Is your Phpwiki internal or available on the Internet?
>
> Best regards,
>
> Marc-Etienne
>
> --
> Marc-Etienne Vargenau mar...@no...
> Nokia, 12, rue Jean-Bart, 91300 Massy, FRANCE
> Mobile: [+33 6 24 49 78 68](tel:+33624497868)
>
> Senior Specialist Open Source
> Planned absence: none
>
> De : Thom Jeera via Phpwiki-talk <php...@li...>
> Date : mardi, 24 octobre 2023 à 21:35
> À : php...@li... <php...@li...>
> Cc : Thom Jeera <tho...@pr...>
> Objet : [Phpwiki-talk] TypeError in ExternalReferrer under php8
>
> CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
>
> Hi - I'm running phpwiki-1.6.2 on php 8.2.11.
>
> I saw an error when someone clicked a phpwiki link from within a gmail app - see bottom of email. The 'google.' in the referer triggers the external referrer code, which breaks under php8 (seems ok in php5 - I couldn't recreate it against phpwiki.demo.free.fr for instance).
>
> Something like this would trigger it under php8:
>
> curl -H 'referer: android-app://com.google.android.gm/' http://phpwiki.demo.free.fr/index.php/SandBox
>
> The code here in ExternalReferrer.php looks inconsistent - if there is no query string (ie the tested value IS empty), then $url is still an array when it gets passed into stristr, hence the error.
>
> if (!empty($url["query"])) {
> $url = $url["query"];
> }
>
> if ($query1 and @stristr($url, $query1)) {
>
> The behaviour is present but the error gets suppressed under earlier versions of php.
>
> Suggested fix: add "else return false;" after the !empty test ?
>
> Reported error:
>
> Got error 'PHP message: PHP Fatal error: Uncaught TypeError: stristr():
> Argument #1 ($haystack) must be of type string, array given in /syshome/webchris/html/phpwiki-1.6.1/lib/ExternalReferrer.php:129
> Stack trace:
> #0 /syshome/webchris/html/phpwiki-1.6.1/lib/ExternalReferrer.php(129): stristr()
> #1 /syshome/webchris/html/phpwiki-1.6.1/lib/stdlib.php(1890): SearchEngines->parseSearchQuery()
> #2 /syshome/webchris/html/phpwiki-1.6.1/lib/display.php(324): isExternalReferrer()
> #3 /syshome/webchris/html/phpwiki-1.6.1/lib/main.php(1069): displayPage()
> #4 /syshome/webchris/html/phpwiki-1.6.1/lib/main.php(816): WikiRequest->action_browse()
> #5 /syshome/webchris/html/phpwiki-1.6.1/lib/main.php(1451): WikiRequest->handleAction()
> #6 /syshome/webchris/html/phpwiki-1.6.1/lib/main.php(1475): main()
> #7 /syshome/webchris/html/phpwiki-1.6.1/index.php(60): include('...')
> #8 {main}
> thrown in /syshome/webchris/html/phpwiki-1.6.1/lib/ExternalReferrer.php on line 129', referer: android-app://com.google.android.gm/
>
> Regards,
> Thom.
>
> _______________________________________________
> Phpwiki-talk mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpwiki-talk 

Hi Thom,
I have just published PhpWiki 1.6.3 with a fix for your issue.
You can download it at: https://sourceforge.net/projects/phpwiki/
Thank you again for your bug report.
Best regards,
Marc-Etienne
--
Marc-Etienne Vargenau mar...@no...<mailto:mar...@no...>
Nokia, 12, rue Jean-Bart, 91300 Massy, FRANCE
Mobile: +33 6 24 49 78 68<tel:+33624497868>
Senior Specialist Open Source
Planned absence: none
De : Marc-Etienne Vargenau (Nokia) <mar...@no...>
Date : mercredi, 8 novembre 2023 à 19:55
À : Discussion on PhpWiki features, bugs, development. <php...@li...>
Cc : Thom Jeera <tho...@pr...>
Objet : Re: [Phpwiki-talk] TypeError in ExternalReferrer under php8
Hi Thom,
Thank you for the report.
I will test and provide a fix.
Is your Phpwiki internal or available on the Internet?
Best regards,
Marc-Etienne
--
Marc-Etienne Vargenau mar...@no...<mailto:mar...@no...>
Nokia, 12, rue Jean-Bart, 91300 Massy, FRANCE
Mobile: +33 6 24 49 78 68<tel:+33624497868>
Senior Specialist Open Source
Planned absence: none
De : Thom Jeera via Phpwiki-talk <php...@li...>
Date : mardi, 24 octobre 2023 à 21:35
À : php...@li... <php...@li...>
Cc : Thom Jeera <tho...@pr...>
Objet : [Phpwiki-talk] TypeError in ExternalReferrer under php8
CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
Hi - I'm running phpwiki-1.6.2 on php 8.2.11.
I saw an error when someone clicked a phpwiki link from within a gmail app - see bottom of email. The 'google.' in the referer triggers the external referrer code, which breaks under php8 (seems ok in php5 - I couldn't recreate it against phpwiki.demo.free.fr for instance).
Something like this would trigger it under php8:
curl -H 'referer: android-app://com.google.android.gm/' http://phpwiki.demo.free.fr/index.php/SandBox
The code here in ExternalReferrer.php looks inconsistent - if there is no query string (ie the tested value IS empty), then $url is still an array when it gets passed into stristr, hence the error.
 if (!empty($url["query"])) {
 $url = $url["query"];
 }
 if ($query1 and @stristr($url, $query1)) {
The behaviour is present but the error gets suppressed under earlier versions of php.
Suggested fix: add "else return false;" after the !empty test ?
Reported error:
Got error 'PHP message: PHP Fatal error: Uncaught TypeError: stristr():
Argument #1 ($haystack) must be of type string, array given in /syshome/webchris/html/phpwiki-1.6.1/lib/ExternalReferrer.php:129
Stack trace:
#0 /syshome/webchris/html/phpwiki-1.6.1/lib/ExternalReferrer.php(129): stristr()
#1 /syshome/webchris/html/phpwiki-1.6.1/lib/stdlib.php(1890): SearchEngines->parseSearchQuery()
#2 /syshome/webchris/html/phpwiki-1.6.1/lib/display.php(324): isExternalReferrer()
#3 /syshome/webchris/html/phpwiki-1.6.1/lib/main.php(1069): displayPage()
#4 /syshome/webchris/html/phpwiki-1.6.1/lib/main.php(816): WikiRequest->action_browse()
#5 /syshome/webchris/html/phpwiki-1.6.1/lib/main.php(1451): WikiRequest->handleAction()
#6 /syshome/webchris/html/phpwiki-1.6.1/lib/main.php(1475): main()
#7 /syshome/webchris/html/phpwiki-1.6.1/index.php(60): include('...')
#8 {main}
 thrown in /syshome/webchris/html/phpwiki-1.6.1/lib/ExternalReferrer.php on line 129', referer: android-app://com.google.android.gm/
Regards,
Thom.
_______________________________________________
Phpwiki-talk mailing list
Php...@li...
https://lists.sourceforge.net/lists/listinfo/phpwiki-talk

Hi Thom,
Thank you for the report.
I will test and provide a fix.
Is your Phpwiki internal or available on the Internet?
Best regards,
Marc-Etienne
--
Marc-Etienne Vargenau mar...@no...<mailto:mar...@no...>
Nokia, 12, rue Jean-Bart, 91300 Massy, FRANCE
Mobile: +33 6 24 49 78 68<tel:+33624497868>
Senior Specialist Open Source
Planned absence: none
De : Thom Jeera via Phpwiki-talk <php...@li...>
Date : mardi, 24 octobre 2023 à 21:35
À : php...@li... <php...@li...>
Cc : Thom Jeera <tho...@pr...>
Objet : [Phpwiki-talk] TypeError in ExternalReferrer under php8
CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
Hi - I'm running phpwiki-1.6.2 on php 8.2.11.
I saw an error when someone clicked a phpwiki link from within a gmail app - see bottom of email. The 'google.' in the referer triggers the external referrer code, which breaks under php8 (seems ok in php5 - I couldn't recreate it against phpwiki.demo.free.fr for instance).
Something like this would trigger it under php8:
curl -H 'referer: android-app://com.google.android.gm/' http://phpwiki.demo.free.fr/index.php/SandBox
The code here in ExternalReferrer.php looks inconsistent - if there is no query string (ie the tested value IS empty), then $url is still an array when it gets passed into stristr, hence the error.
 if (!empty($url["query"])) {
 $url = $url["query"];
 }
 if ($query1 and @stristr($url, $query1)) {
The behaviour is present but the error gets suppressed under earlier versions of php.
Suggested fix: add "else return false;" after the !empty test ?
Reported error:
Got error 'PHP message: PHP Fatal error: Uncaught TypeError: stristr():
Argument #1 ($haystack) must be of type string, array given in /syshome/webchris/html/phpwiki-1.6.1/lib/ExternalReferrer.php:129
Stack trace:
#0 /syshome/webchris/html/phpwiki-1.6.1/lib/ExternalReferrer.php(129): stristr()
#1 /syshome/webchris/html/phpwiki-1.6.1/lib/stdlib.php(1890): SearchEngines->parseSearchQuery()
#2 /syshome/webchris/html/phpwiki-1.6.1/lib/display.php(324): isExternalReferrer()
#3 /syshome/webchris/html/phpwiki-1.6.1/lib/main.php(1069): displayPage()
#4 /syshome/webchris/html/phpwiki-1.6.1/lib/main.php(816): WikiRequest->action_browse()
#5 /syshome/webchris/html/phpwiki-1.6.1/lib/main.php(1451): WikiRequest->handleAction()
#6 /syshome/webchris/html/phpwiki-1.6.1/lib/main.php(1475): main()
#7 /syshome/webchris/html/phpwiki-1.6.1/index.php(60): include('...')
#8 {main}
 thrown in /syshome/webchris/html/phpwiki-1.6.1/lib/ExternalReferrer.php on line 129', referer: android-app://com.google.android.gm/
Regards,
Thom.
_______________________________________________
Phpwiki-talk mailing list
Php...@li...
https://lists.sourceforge.net/lists/listinfo/phpwiki-talk

Hi - I'm running phpwiki-1.6.2 on php 8.2.11.
I saw an error when someone clicked a phpwiki link from within a gmail app - see bottom of email. The 'google.' in the referer triggers the external referrer code, which breaks under php8 (seems ok in php5 - I couldn't recreate it against phpwiki.demo.free.fr for instance).
Something like this would trigger it under php8:
curl -H 'referer: android-app://com.google.android.gm/' http://phpwiki.demo.free.fr/index.php/SandBox
The code here in ExternalReferrer.php looks inconsistent - if there is no query string (ie the tested value IS empty), then $url is still an array when it gets passed into stristr, hence the error.
 if (!empty($url["query"])) {
 $url = $url["query"];
 }
 if ($query1 and @stristr($url, $query1)) {
The behaviour is present but the error gets suppressed under earlier versions of php.
Suggested fix: add "else return false;" after the !empty test ?
Reported error:
Got error 'PHP message: PHP Fatal error: Uncaught TypeError: stristr():
Argument #1 ($haystack) must be of type string, array given in /syshome/webchris/html/phpwiki-1.6.1/lib/ExternalReferrer.php:129
Stack trace:
#0 /syshome/webchris/html/phpwiki-1.6.1/lib/ExternalReferrer.php(129): stristr()
#1 /syshome/webchris/html/phpwiki-1.6.1/lib/stdlib.php(1890): SearchEngines->parseSearchQuery()
#2 /syshome/webchris/html/phpwiki-1.6.1/lib/display.php(324): isExternalReferrer()
#3 /syshome/webchris/html/phpwiki-1.6.1/lib/main.php(1069): displayPage()
#4 /syshome/webchris/html/phpwiki-1.6.1/lib/main.php(816): WikiRequest->action_browse()
#5 /syshome/webchris/html/phpwiki-1.6.1/lib/main.php(1451): WikiRequest->handleAction()
#6 /syshome/webchris/html/phpwiki-1.6.1/lib/main.php(1475): main()
#7 /syshome/webchris/html/phpwiki-1.6.1/index.php(60): include('...')
#8 {main}
 thrown in /syshome/webchris/html/phpwiki-1.6.1/lib/ExternalReferrer.php on line 129', referer: android-app://com.google.android.gm/
Regards,
Thom.

Hi Christof,
Thank you for your report.
I will include your patch in the next release.
Best regards,
Marc-Etienne
-----Original Message-----
From: Christof Meerwald <cm...@cm...> 
Sent: Wednesday, February 9, 2022 7:08 PM
To: php...@li...
Subject: [Phpwiki-talk] Calendar and CalendarList plugins return incorrect links array
Hi,
just noticed that both the Calendar and CalendarList plugins return incorrect links array from "getWikiPageLinks".
Attached is a patch for this, although removing the whole getWikiPageLinks from those plugins might be the better option (as the comment says "static only as of action=edit") as it's not really useful that way.
Christof
-- 
https://cmeerw.org sip:cmeerw at cmeerw.org
mailto:cmeerw at cmeerw.org xmpp:cmeerw at cmeerw.org

Hi,
just noticed that both the Calendar and CalendarList plugins return
incorrect links array from "getWikiPageLinks".
Attached is a patch for this, although removing the whole
getWikiPageLinks from those plugins might be the better option (as the
comment says "static only as of action=edit") as it's not really
useful that way.
Christof
-- 
https://cmeerw.org sip:cmeerw at cmeerw.org
mailto:cmeerw at cmeerw.org xmpp:cmeerw at cmeerw.org

Hi Harold,
Yes, the uploads are not included in a wiki dump.
I need to check if this is easily doable.
Best regards,
Marc-Etienne
-----Original Message-----
From: Harold Hallikainen <ha...@ha...> 
Sent: Tuesday, January 18, 2022 8:37 PM
To: php...@li...
Subject: Re: [Phpwiki-talk] Upload URL has double slash between host and path
Perfect! Just installed phpwiki-code-r10908-trunk.zip, and that fixed the upload URL issue.
I note that uploads are not included in a wiki dump and need to be copied separately. Any chance of including uploads in the dump?
THANKS!
Harold
On Tue, January 18, 2022 7:12 am, Vargenau, Marc-Etienne (Nokia -
FR/Paris-Saclay) wrote:
> Hi Harold,
>
> This was happening when DATA_PATH is empty.
> Fixed in Subversion 10905.
>
> Best regards,
>
> Marc-Etienne
>
> -----Original Message-----
> From: Harold Hallikainen <ha...@ha...>
> Sent: Tuesday, January 18, 2022 6:09 AM
> To: php...@li...
> Subject: [Phpwiki-talk] Upload URL has double slash between host and 
> path
>
> This doesn't seem to cause an issue with browsers, but I am seeing a 
> double slash between the hostname and the path.
>
> For example,
>
> https://bh.hallikainen.org//uploads/harold/Drc190Data.pdf
>
> In config.ini, neither UPLOAD_FILE_PATH nor UPLOAD_DATA_PATH are 
> overridden.
>
> Harold
>
>
>
> --
> FCC Rules Updated Daily at http://www.hallikainen.com Not sent from an 
> iPhone.
>
>
> _______________________________________________
> Phpwiki-talk mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpwiki-talk
>
>
> _______________________________________________
> Phpwiki-talk mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpwiki-talk
>
>
--
FCC Rules Updated Daily at http://www.hallikainen.com Not sent from an iPhone.
_______________________________________________
Phpwiki-talk mailing list
Php...@li...
https://lists.sourceforge.net/lists/listinfo/phpwiki-talk