-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: improve repo workflow and configuration #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor comments/questions, but overall lgtm 🎉
@gkalpak PR ready for final review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :shipit:
Both @Splaktar comments applied. Ready for final review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package.json's engines field requires npm v6, but this PR updates the package-lock.json version to v2. I think that we should ensure that we only use npm v6 with this repo and rollback the changes to the package-lock.json file from npm v7 or v8.
The package.json's engines field requires npm v6, but this PR updates the package-lock.json version to v2. I think that we should ensure that we only use npm v6 with this repo and rollback the changes to the package-lock.json file from npm v7 or v8.
I set the engine-strict flag in .npmrc. I updated the npm and node versions in the package.json engines: npm v9, node>=18. I tested if the package installation and start of the application works correctly. Everything looks fine
@jzolnowski please rebase and resolve conflicts.
Let's make any npm and node changes in a separate PR.
b39ce6b to
8b065f2
Compare
Let's make any npm and node changes in a separate PR.
Separate PR created
Branch is up-to-date with master
10258f8 to
dca9fcf
Compare
Rebased branch with master
@jzolnowski please rebase and resolve conflicts.
dca9fcf to
b0f0d54
Compare
@jzolnowski please rebase and resolve conflicts.
Rebased branch with master
@jzolnowski please rebase and resolve conflicts.
...d www/lib into gitignore, create lib folder before copy deps
...ackages script, reorder folders in gitignore
...move www/lib folder before create a new one
4954529 to
fc63875
Compare
Rebased branch with master
Uh oh!
There was an error while loading. Please reload this page.
Improve workflow to not worry about the
www/lib/directory