-
Notifications
You must be signed in to change notification settings - Fork 0
chore: update engines fields in package.json (Node.js: 14, npm: 6)
#10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jzolnowski
jzolnowski
changed the title
(削除) chore: Set engine npm version to 9 and node to above or equal 18, upd... (削除ここまで)
(追記) chore: Set engine npm version to 9 and node to above or equal 18 (追記ここまで)
Mar 17, 2023
gkalpak
gkalpak
approved these changes
Mar 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
...ate .nvmrc to use node 18
@jzolnowski
jzolnowski
force-pushed
the
chore/bump-to-node-18
branch
from
April 7, 2023 11:27
db76c16 to
811d175
Compare
engines.node field in package.json set to v14
Branch up-to-date with master
@gkalpak
gkalpak
changed the title
(削除) chore: Set engine npm version to 9 and node to above or equal 18 (削除ここまで)
(追記) chore: update Apr 7, 2023
engines fields in package.json (Node.js >=14, npm >=6) (追記ここまで)
gkalpak
gkalpak
approved these changes
Apr 7, 2023
gkalpak
gkalpak
requested changes
Apr 7, 2023
...json, set nvmrc node to v14
@jzolnowski
jzolnowski
force-pushed
the
chore/bump-to-node-18
branch
from
April 12, 2023 10:28
811d175 to
02c5d3b
Compare
@gkalpak PR ready for another round of review
@gkalpak
gkalpak
changed the title
(削除) chore: update
(追記) chore: update Apr 12, 2023
engines fields in package.json (Node.js >=14, npm >=6) (削除ここまで)engines fields in package.json (Node.js: 14, npm: 6) (追記ここまで)
gkalpak
gkalpak
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Splaktar
Splaktar
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Related with comment #9 (comment)