-
Notifications
You must be signed in to change notification settings - Fork 0
build(codeql): enabling code scanning #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.
Let's put this on hold, until we finalize the proper configuration/approach in xlts-dev/angularjs-webpack-babel#29.
46457ab to
d505612
Compare
We can use CodeQL to identify vulnerabilities and errors in our JavaScript code and display the results as code scanning alerts on GitHub
ef55ef5 to
3216297
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code scanning found an issue: https://github.com/xlts-dev/angularjs-ionic-v1/security/code-scanning/1
It is a false positive, but maybe we could refactor the code to avoid triggering the warning.
Otherwise, the PR lgtm 👍
c553c97 to
5641097
Compare
... the first occurrence of '>'
5641097 to
732d4f6
Compare
We can use CodeQL to identify vulnerabilities and errors in our JavaScript code and display the results as code scanning alerts on GitHub